chore: Fix flaky permissions test (#10074)

- the permissions tests were failing when the random number turns out to
be 0, fixing this case and ensuring that its always between, 1-4.

spec/enterprise/controllers/api/v1/accounts/custom_roles_controller_spec.rb

@@ -69,7 +69,8 @@ RSpec.describe 'Custom Roles API', type: :request do
 
   describe 'POST #create' do
     let(:valid_params) do
-      { custom_role: { name: 'Support', description: 'Support role', permissions: CustomRole::PERMISSIONS.sample(SecureRandom.random_number(4)) } }
+      { custom_role: { name: 'Support', description: 'Support role',
+                       permissions: CustomRole::PERMISSIONS.sample(SecureRandom.random_number(1..4)) } }
     end
 
     context 'when it is an authenticated administrator' do

spec/factories/custom_roles.rb

@@ -3,6 +3,6 @@ FactoryBot.define do
     account
     name { Faker::Name.name }
     description { Faker::Lorem.sentence }
-    permissions { CustomRole::PERMISSIONS.sample(SecureRandom.random_number(4)) }
+    permissions { CustomRole::PERMISSIONS.sample(SecureRandom.random_number(1..4)) }
   end
 end