LeadMagnet/leadchat
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

fix: Raise error if email to_header is invalid (#8688)

Browse Source
This commit is contained in:
Vishnu Narayanan
2024-02-21 06:33:39 +05:30
committed by GitHub
parent 9911c5dc12
commit d53097f77d
4 changed files with 90 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
spec/fixtures/files/mail_with_invalid_to.eml vendored Normal file
View File

@@ -0,0 +1,29 @@
X-Original-To: bd84c730a1ac7833e4d27253804516f7@reply.chatwoot.com
Received: from mail.planetmars.com (mxd [192.168.1.1]) by mx.sendgrid.net with ESMTP id AAAA-bCCCCCC5DeeeFFgg for <bd84c730a1ac7833e4d27253804516f7@reply.chatwoot.com>; Sun, 31 Dec 2023 22:32:23.586 +0000 (UTC)
From: "Mark Whatney" <mark@planetmars.com>
To: <vishnu@chatwoot.com>vishnu@chatwoot.com
Subject: stranded in mars
Date: Mon, 1 Jan 2024 06:31:44 +0800
Message-ID: <1234560e0123c05b4bbf83c828b1688a93c7@com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
boundary=15688136a4ad411d82b004fae6e46549
X-Exim-Id: 1234560e0123c05b4bbf83c828b1688a93c7
This is a multipart message in MIME format.
--15688136a4ad411d82b004fae6e46549
Content-Type: text/plain;
charset="us-ascii"
Content-Transfer-Encoding: 7bit
hey v, can i get some help over here?
--15688136a4ad411d82b004fae6e46549
Content-Type: text/html;
charset="utf-8"
Content-Transfer-Encoding: quoted-printable
hey v, can i get some help over here?
--15688136a4ad411d82b004fae6e46549--

29
spec/fixtures/files/mail_with_invalid_to_2.eml vendored Normal file
View File

@@ -0,0 +1,29 @@
X-Original-To: bd84c730a1ac7833e4d27253804516f7@reply.chatwoot.com
Received: from mail.planetmars.com (mxd [192.168.1.1]) by mx.sendgrid.net with ESMTP id AAAA-bCCCCCC5DeeeFFgg for <bd84c730a1ac7833e4d27253804516f7@reply.chatwoot.com>; Sun, 31 Dec 2023 22:32:23.586 +0000 (UTC)
From: "Mark Whatney" <mark@planetmars.com>
To: vishnu@chatwoot.com www.chatwoot.com
Subject: stranded in mars
Date: Mon, 1 Jan 2024 06:31:44 +0800
Message-ID: <1234560e0123c05b4bbf83c828b1688a93c7@com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
boundary=15688136a4ad411d82b004fae6e46549
X-Exim-Id: 1234560e0123c05b4bbf83c828b1688a93c7
This is a multipart message in MIME format.
--15688136a4ad411d82b004fae6e46549
Content-Type: text/plain;
charset="us-ascii"
Content-Transfer-Encoding: 7bit
hey v, can i get some help over here?
--15688136a4ad411d82b004fae6e46549
Content-Type: text/html;
charset="utf-8"
Content-Transfer-Encoding: quoted-printable
hey v, can i get some help over here?
--15688136a4ad411d82b004fae6e46549--

18
spec/mailboxes/application_mailbox_spec.rb
View File

@@ -10,6 +10,8 @@ RSpec.describe ApplicationMailbox do
let(:reply_mail_without_uuid) { create_inbound_email_from_fixture('reply.eml') }
let(:reply_mail_with_in_reply_to) { create_inbound_email_from_fixture('in_reply_to.eml') }
let(:support_mail) { create_inbound_email_from_fixture('support.eml') }
let(:mail_with_invalid_to_address) { create_inbound_email_from_fixture('mail_with_invalid_to.eml') }
let(:mail_with_invalid_to_address_2) { create_inbound_email_from_fixture('mail_with_invalid_to_2.eml') }
describe 'Default' do
it 'catchall mails route to Default Mailbox' do
@@ -65,5 +67,21 @@ RSpec.describe ApplicationMailbox do
described_class.route reply_cc_mail
end
end
describe 'Invalid Mail To Address' do
it 'raises error when mail.to header is malformed' do
expect do
described_class.route mail_with_invalid_to_address
end.to raise_error(StandardError,
'Invalid email to address header <vishnu@chatwoot.com>vishnu@chatwoot.com')
end
it 'raises another error when mail.to header is malformed' do
expect do
described_class.route mail_with_invalid_to_address_2
end.to raise_error(StandardError,
'Invalid email to address header vishnu@chatwoot.com www.chatwoot.com')
end
end
end
end