diff --git a/app/presenters/mail_presenter.rb b/app/presenters/mail_presenter.rb index 08e370cd8..62cb0ed9a 100644 --- a/app/presenters/mail_presenter.rb +++ b/app/presenters/mail_presenter.rb @@ -130,11 +130,15 @@ class MailPresenter < SimpleDelegator end def sender_name - Mail::Address.new((@mail[:reply_to] || @mail[:from]).value).name + parse_mail_address((@mail[:reply_to] || @mail[:from]).value)&.name end def original_sender - from_email_address(@mail[:reply_to].try(:value)) || @mail['X-Original-Sender'].try(:value) || from_email_address(from.first) + [ + @mail[:reply_to]&.value, + @mail['X-Original-Sender']&.value, + @mail[:from]&.value + ].filter_map { |email| parse_mail_address(email)&.address }.first end def headers_data @@ -147,10 +151,6 @@ class MailPresenter < SimpleDelegator headers.presence end - def from_email_address(email) - Mail::Address.new(email).address - end - def email_forwarded_for @mail['X-Forwarded-For'].try(:value) end @@ -175,11 +175,20 @@ class MailPresenter < SimpleDelegator def notification_email_from_chatwoot? # notification emails are send via mailer sender email address. so it should match - original_sender == Mail::Address.new(ENV.fetch('MAILER_SENDER_EMAIL', 'Chatwoot ')).address + configured_sender = Mail::Address.new(ENV.fetch('MAILER_SENDER_EMAIL', 'Chatwoot ')).address + original_sender.to_s.casecmp?(configured_sender) end private + def parse_mail_address(email) + return if email.blank? + + Mail::Address.new(email) + rescue Mail::Field::ParseError, Mail::Field::IncompleteParseError + nil + end + def auto_submitted? @mail['Auto-Submitted'].present? && @mail['Auto-Submitted'].value != 'no' end diff --git a/spec/presenters/mail_presenter_spec.rb b/spec/presenters/mail_presenter_spec.rb index bbe51c52d..f5ed27537 100644 --- a/spec/presenters/mail_presenter_spec.rb +++ b/spec/presenters/mail_presenter_spec.rb @@ -178,5 +178,85 @@ RSpec.describe MailPresenter do expect(decorated_mail.serialized_data[:auto_reply]).to be_falsey end end + + describe 'malformed sender headers' do + let(:mail_with_malformed_from) do + Mail.new do + header['From'] = 'Kevin McDonald ' + subject :header + body 'Hi' + end + end + + let(:mail_with_malformed_reply_to) do + Mail.new do + from 'Sender ' + to 'Inbox ' + subject :header + body 'Hi' + header['Reply-To'] = 'Reply User ' + to 'Inbox ' + subject :header + body 'Hi' + header['Reply-To'] = 'Reply User ' + to 'Inbox ' + subject :header + body 'Hi' + header['Reply-To'] = 'Reply User ' + to 'Inbox ' + subject :header + body 'Hi' + end + + with_modified_env MAILER_SENDER_EMAIL: 'Chatwoot ' do + presenter = described_class.new(mail_with_uppercase_sender) + expect(presenter.notification_email_from_chatwoot?).to be(true) + end + end + end end end