chore: Use find_each instead of .all.each (#6975)

- Enable the rubocop Rails/FindEach
- Replace the .all.each with .find_each

This should let us avoid potential memory usage.
Motivation from the speedshop newsletter by Nate Berkopec

ref: https://www.rubyinrails.com/2017/11/16/use-find-each-instead-of-all-each-in-rails/
ref: https://linear.app/chatwoot/issue/CW-1480/chore-run-all-sidekiq-jobs-async
This commit is contained in:
Sojan Jose
2023-04-25 09:32:35 +05:30
committed by GitHub
parent b529baa5eb
commit cf91e9eb58
9 changed files with 12 additions and 11 deletions

View File

@@ -6,7 +6,7 @@ class Migration::UpdateFirstResponseTimeInReportingEventsJob < ApplicationJob
def perform(account)
get_conversations_with_bot_handoffs(account)
account.reporting_events.where(name: 'first_response').each do |event|
account.reporting_events.where(name: 'first_response').find_each do |event|
conversation = event.conversation
# if the conversation has a bot handoff event, we don't need to update the response_time