From ce8e1ec93dbf2c0d5253da82bf4c0cdd6f16dc66 Mon Sep 17 00:00:00 2001 From: Fayaz Ahmed Date: Tue, 30 Jul 2024 15:08:22 +0530 Subject: [PATCH] chore: Migrate all instances of old vuelidate to new v2 syntax [CW-3274] (#9623) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Removes all the old vuelidate syntax and replaced it with the new `useValidate` composable and the `v$` helper. | Component | Path | Migrated | Tested | |------------------------------------|--------------------------------------------------------------|-----------------------------------------------|--------| | Login page | app/javascript/v3/views/login/Index.vue | ✅ | ✅ | | Custom Attributes settings page | app/javascript/dashboard/components/CustomAttribute.vue | ✅ | ✅ | | Account settings page | app/javascript/dashboard/routes/dashboard/settings/account/Index.vue | ✅ | ✅ | | Add Account Modal | app/javascript/dashboard/components/layout/sidebarComponents/AddAccountModal.vue | ✅ | ✅ | | AICTA Modal | app/javascript/dashboard/components/widgets/AICTAModal.vue | ✅ | ✅ | | Conversation Advanced Filters | app/javascript/dashboard/components/widgets/conversation/ConversationAdvancedFilter.vue | deprecated `$each` prop in validations object | | | Email Transript Modal | app/javascript/dashboard/components/widgets/conversation/EmailTranscriptModal.vue | ✅ | ✅ | | Linear Create Issue | app/javascript/dashboard/components/widgets/conversation/linear/CreateIssue.vue | ✅ | ✅ | | Template Parser | app/javascript/dashboard/components/widgets/conversation/WhatsappTemplates/TemplateParser.vue | ✅ | | | Delete Confirmation Modal | app/javascript/dashboard/components/widgets/modal/ConfirmDeleteModal.vue | ✅ | ✅ | | Add Custom Attribute | app/javascript/dashboard/modules/contact/components/AddCustomAttribute.vue | ✅ | ✅ | | Merge Contacts | app/javascript/dashboard/modules/contact/components/MergeContact.vue | ✅ | ✅ | | Contacts Advanced Filters | app/javascript/dashboard/routes/dashboard/contacts/components/ContactsAdvancedFilters.vue | deprecated `$each` prop in validations object | | | Contact Form | app/javascript/dashboard/routes/dashboard/conversation/contact/ContactForm.vue | ✅ | ✅ | | Conversation Form | app/javascript/dashboard/routes/dashboard/conversation/contact/ConversationForm.vue | ✅ | ✅ | | Add Custom Views | app/javascript/dashboard/routes/dashboard/customviews/AddCustomViews.vue | ✅ | ✅ | | Add Locale | app/javascript/dashboard/routes/dashboard/helpcenter/components/AddLocale.vue | ✅ | ✅ | | Portal Settings Basic Form | /app/javascript/dashboard/routes/dashboard/helpcenter/components/PortalSettingsBasicForm.vue | ✅ | ✅ | | Portal Settings Customization Form | /app/javascript/dashboard/routes/dashboard/helpcenter/components/PortalSettingsCustomizationForm.vue | ✅ | ✅ | | Add Category | app/javascript/dashboard/routes/dashboard/helpcenter/pages/categories/AddCategory.vue | ✅ | ✅ | | Edit Category | app/javascript/dashboard/routes/dashboard/helpcenter/pages/categories/EditCategory.vue | ✅ | ✅ | | CSML Bot Editor | app/javascript/dashboard/routes/dashboard/settings/agentBots/components/CSMLBotEditor.vue | ✅ | ✅ | | Add Agent | app/javascript/dashboard/routes/dashboard/settings/agents/AddAgent.vue | ✅ | ✅ | | Edit Agent | app/javascript/dashboard/routes/dashboard/settings/agents/EditAgent.vue | ✅ | ✅ | | Add Attribute | app/javascript/dashboard/routes/dashboard/settings/attributes/AddAttribute.vue | ✅ | ✅ | | Edit Attribute | app/javascript/dashboard/routes/dashboard/settings/attributes/EditAttribute.vue | ✅ | ✅ | | Add Campaign | app/javascript/dashboard/routes/dashboard/settings/campaigns/AddCampaign.vue | ✅ | ✅ | | Edit Campaign | app/javascript/dashboard/routes/dashboard/settings/campaigns/EditCampaign.vue | ✅ | ✅ | | Add Canned | app/javascript/dashboard/routes/dashboard/settings/canned/AddCanned.vue | ✅ | ✅ | | Edit Canned | app/javascript/dashboard/routes/dashboard/settings/canned/EditCanned.vue | ✅ | ✅ | | IMAP Settings | app/javascript/dashboard/routes/dashboard/settings/inbox/ImapSettings.vue | ✅ | ✅ | | SMTP Settings | app/javascript/dashboard/routes/dashboard/settings/inbox/SmtpSettings.vue | ✅ | ✅ | | Widget Builder | app/javascript/dashboard/routes/dashboard/settings/inbox/WidgetBuilder.vue | ✅ | ✅ | | 360 Dialog Whatsapp | app/javascript/dashboard/routes/dashboard/settings/inbox/channels/360DialogWhatsapp.vue | ✅ | ✅ | | Inbox API settings | app/javascript/dashboard/routes/dashboard/settings/inbox/channels/Api.vue | ✅ | ✅ | | SMS Bandwidth settings | app/javascript/dashboard/routes/dashboard/settings/inbox/channels/BandwidthSms.vue | ✅ | ✅ | | Cloud Whatsapp Settings | app/javascript/dashboard/routes/dashboard/settings/inbox/channels/CloudWhatsapp.vue | ✅ | ✅ | | Facebook Settings | app/javascript/dashboard/routes/dashboard/settings/inbox/channels/Facebook.vue | ✅ | ✅ | | Line Settings | app/javascript/dashboard/routes/dashboard/settings/inbox/channels/Line.vue | ✅ | ✅ | | Telegram Settings | app/javascript/dashboard/routes/dashboard/settings/inbox/channels/Telegram.vue | ✅ | ✅ | | Twillio Settings | app/javascript/dashboard/routes/dashboard/settings/inbox/channels/Twilio.vue | ✅ | ✅ | | Forward To option settings | app/javascript/dashboard/routes/dashboard/settings/inbox/channels/emailChannels/ForwardToOption.vue | ✅ | ✅ | | Microsoft settings | app/javascript/dashboard/routes/dashboard/settings/inbox/channels/emailChannels/Microsoft.vue | ✅ | ✅ | | Collaborators page | app/javascript/dashboard/routes/dashboard/settings/inbox/settingsPage/CollaboratorsPage.vue | ✅ | ✅ | | Configuration Page | app/javascript/dashboard/routes/dashboard/settings/inbox/settingsPage/ConfigurationPage.vue | ✅ | ✅ | | Dashboard App Modal Settings | app/javascript/dashboard/routes/dashboard/settings/integrations/DashboardApps/DashboardAppModal.vue | ✅ | ✅ | | Settings - Webhook Form | app/javascript/dashboard/routes/dashboard/settings/integrations/Webhooks/WebhookForm.vue | ✅ | ✅ | | Macro Form | app/javascript/dashboard/routes/dashboard/settings/macros/MacroForm.vue | deprecated `$each` prop in validations object | | | Change Password | app/javascript/dashboard/routes/dashboard/settings/profile/ChangePassword.vue | ✅ | ✅ | | settings - User Basic Details | app/javascript/dashboard/routes/dashboard/settings/profile/UserBasicDetails.vue | ✅ | ✅ | | Password Edit | app/javascript/v3/views/auth/password/Edit.vue | ✅ | ✅ | | Password Reset form | app/javascript/v3/views/auth/reset/password/Index.vue | ✅ | ✅ | | Signup form | app/javascript/v3/views/auth/signup/components/Signup/Form.vue | ✅ | ✅ | | Login form | app/javascript/v3/views/login/Index.vue | ✅ | ✅ | | Custom Attributes | app/javascript/dashboard/components/CustomAttribute.vue | ✅ | ✅ | | Reply Email Head | app/javascript/dashboard/components/widgets/conversation/ReplyEmailHead.vue | ✅ | ✅ | | Methods Mixin | app/javascript/dashboard/mixins/automations/methodsMixin.js | ✅ | ✅ | | Validations mixin | app/javascript/dashboard/routes/dashboard/settings/labels/validationMixin.js | ✅ | ✅ | | SLA Form | app/javascript/dashboard/routes/dashboard/settings/sla/SlaForm.vue | ✅ | ✅ | | SLA Time Input | app/javascript/dashboard/routes/dashboard/settings/sla/SlaTimeInput.vue | ✅ | ✅ | | SLA Validation Mixin | app/javascript/dashboard/routes/dashboard/settings/sla/validationMixin.js | ✅ | ✅ | | Team Form | app/javascript/dashboard/routes/dashboard/settings/teams/TeamForm.vue | ✅ | ✅ | | Add Agents | app/javascript/dashboard/routes/dashboard/settings/teams/Create/AddAgents.vue | ✅ | ✅ | | Edit Agents | app/javascript/dashboard/routes/dashboard/settings/teams/Edit/EditAgents.vue | ✅ | ✅ | --------- Co-authored-by: Muhsin Keloth Co-authored-by: Shivam Mishra Co-authored-by: Sivin Varghese <64252451+iamsivin@users.noreply.github.com> Co-authored-by: Pranav --- .storybook/preview.js | 4 +- .../dashboard/components/CustomAttribute.vue | 28 +-- .../sidebarComponents/AddAccountModal.vue | 14 +- .../components/widgets/AICTAModal.vue | 14 +- .../widgets/AutomationActionInput.vue | 15 +- .../components/widgets/FilterInput/Index.vue | 18 +- .../ConversationAdvancedFilter.vue | 61 ++---- .../conversation/EmailTranscriptModal.vue | 14 +- .../widgets/conversation/ReplyEmailHead.vue | 28 +-- .../WhatsappTemplates/TemplateParser.vue | 12 +- .../conversation/helpers/emailHeadHelper.js | 4 +- .../widgets/modal/ConfirmDeleteModal.vue | 13 +- .../helper/specs/validations.spec.js | 127 ++++++++++++ .../dashboard/helper/validations.js | 193 ++++++++++++++++++ .../dashboard/i18n/locale/en/automation.json | 16 +- .../dashboard/i18n/locale/en/macros.json | 9 + .../mixins/automations/methodsMixin.js | 13 +- .../mixins/automations/validationsMixin.js | 44 ---- .../contact/components/AddCustomAttribute.vue | 14 +- .../contact/components/MergeContact.vue | 14 +- .../components/ContactsAdvancedFilters.vue | 57 +++--- .../conversation/contact/ContactForm.vue | 26 ++- .../conversation/contact/ConversationForm.vue | 37 ++-- .../dashboard/customviews/AddCustomViews.vue | 19 +- .../helpcenter/components/AddLocale.vue | 17 +- .../pages/categories/AddCategory.vue | 18 +- .../pages/categories/EditCategory.vue | 18 +- .../dashboard/settings/account/Index.vue | 28 +-- .../agentBots/components/CSMLBotEditor.vue | 16 +- .../dashboard/settings/agents/AddAgent.vue | 22 +- .../dashboard/settings/agents/EditAgent.vue | 22 +- .../settings/attributes/AddAttribute.vue | 43 ++-- .../settings/attributes/EditAttribute.vue | 36 ++-- .../settings/automation/AddAutomationRule.vue | 63 +++--- .../automation/EditAutomationRule.vue | 36 ++-- .../settings/campaigns/AddCampaign.vue | 61 +++--- .../settings/campaigns/EditCampaign.vue | 42 ++-- .../dashboard/settings/canned/AddCanned.vue | 24 ++- .../dashboard/settings/canned/EditCanned.vue | 26 ++- .../dashboard/settings/inbox/AddAgents.vue | 15 +- .../dashboard/settings/inbox/ImapSettings.vue | 24 ++- .../dashboard/settings/inbox/Settings.vue | 20 +- .../dashboard/settings/inbox/SmtpSettings.vue | 28 +-- .../settings/inbox/WidgetBuilder.vue | 14 +- .../inbox/channels/360DialogWhatsapp.vue | 30 +-- .../dashboard/settings/inbox/channels/Api.vue | 20 +- .../settings/inbox/channels/BandwidthSms.vue | 48 +++-- .../settings/inbox/channels/CloudWhatsapp.vue | 42 ++-- .../settings/inbox/channels/Facebook.vue | 22 +- .../settings/inbox/channels/Line.vue | 28 +-- .../settings/inbox/channels/Telegram.vue | 14 +- .../settings/inbox/channels/Twilio.vue | 48 +++-- .../emailChannels/ForwardToOption.vue | 20 +- .../inbox/settingsPage/CollaboratorsPage.vue | 16 +- .../inbox/settingsPage/ConfigurationPage.vue | 8 +- .../DashboardApps/DashboardAppModal.vue | 24 ++- .../integrations/Webhooks/WebhookForm.vue | 16 +- .../dashboard/settings/labels/AddLabel.vue | 16 +- .../dashboard/settings/labels/EditLabel.vue | 16 +- .../dashboard/settings/labels/validations.js | 2 +- .../dashboard/settings/macros/MacroForm.vue | 57 +++--- .../dashboard/settings/macros/MacroNode.vue | 22 +- .../dashboard/settings/macros/MacroNodes.vue | 6 + .../settings/macros/MacroProperties.vue | 6 +- .../settings/profile/ChangePassword.vue | 31 +-- .../settings/profile/UserBasicDetails.vue | 28 +-- .../routes/dashboard/settings/sla/SlaForm.vue | 16 +- .../dashboard/settings/sla/SlaTimeInput.vue | 14 +- .../dashboard/settings/sla/validations.js | 7 +- .../settings/teams/Create/AddAgents.vue | 9 +- .../settings/teams/Edit/EditAgents.vue | 11 +- .../dashboard/settings/teams/TeamForm.vue | 18 +- .../settings/teams/helpers/validations.js | 2 +- app/javascript/packs/application.js | 2 - app/javascript/packs/survey.js | 2 - app/javascript/packs/v3app.js | 3 +- app/javascript/packs/widget.js | 3 +- .../mixins/specs/automationMixin.spec.js | 13 -- .../whatsappTemplates.spec.js | 2 - .../v3/views/auth/password/Edit.vue | 18 +- .../v3/views/auth/reset/password/Index.vue | 12 +- .../auth/signup/components/Signup/Form.vue | 36 ++-- app/javascript/v3/views/login/Index.vue | 16 +- .../widget/components/template/EmailInput.vue | 14 +- package.json | 1 - yarn.lock | 36 +--- 86 files changed, 1275 insertions(+), 847 deletions(-) create mode 100644 app/javascript/dashboard/helper/specs/validations.spec.js create mode 100644 app/javascript/dashboard/helper/validations.js delete mode 100644 app/javascript/dashboard/mixins/automations/validationsMixin.js diff --git a/.storybook/preview.js b/.storybook/preview.js index 3f98c2cd8..7c046d51a 100644 --- a/.storybook/preview.js +++ b/.storybook/preview.js @@ -2,7 +2,6 @@ import { addDecorator } from '@storybook/vue'; import Vue from 'vue'; import Vuex from 'vuex'; import VueI18n from 'vue-i18n'; -import Vuelidate from 'vuelidate'; import Multiselect from 'vue-multiselect'; import VueDOMPurifyHTML from 'vue-dompurify-html'; import FluentIcon from 'shared/components/FluentIcon/DashboardIcon'; @@ -14,7 +13,6 @@ import { domPurifyConfig } from 'shared/helpers/HTMLSanitizer'; import '../app/javascript/dashboard/assets/scss/storybook.scss'; Vue.use(VueI18n); -Vue.use(Vuelidate); Vue.use(WootUiKit); Vue.use(Vuex); Vue.use(VueDOMPurifyHTML, domPurifyConfig); @@ -32,7 +30,7 @@ addDecorator(() => ({ template: '', i18n: i18nConfig, store, - beforeCreate: function() { + beforeCreate: function () { this.$root._i18n = this.$i18n; }, })); diff --git a/app/javascript/dashboard/components/CustomAttribute.vue b/app/javascript/dashboard/components/CustomAttribute.vue index e7de811d6..3bd08dac7 100644 --- a/app/javascript/dashboard/components/CustomAttribute.vue +++ b/app/javascript/dashboard/components/CustomAttribute.vue @@ -14,7 +14,7 @@
@@ -136,12 +136,13 @@ - diff --git a/app/javascript/dashboard/routes/dashboard/settings/automation/EditAutomationRule.vue b/app/javascript/dashboard/routes/dashboard/settings/automation/EditAutomationRule.vue index 68d236033..c19ef63bd 100644 --- a/app/javascript/dashboard/routes/dashboard/settings/automation/EditAutomationRule.vue +++ b/app/javascript/dashboard/routes/dashboard/settings/automation/EditAutomationRule.vue @@ -7,30 +7,22 @@ v-model="automation.name" :label="$t('AUTOMATION.ADD.FORM.NAME.LABEL')" type="text" - :class="{ error: $v.automation.name.$error }" - :error=" - $v.automation.name.$error - ? $t('AUTOMATION.ADD.FORM.NAME.ERROR') - : '' - " + :class="{ error: errors.name }" + :error="errors.name ? $t('AUTOMATION.ADD.FORM.NAME.ERROR') : ''" :placeholder="$t('AUTOMATION.ADD.FORM.NAME.PLACEHOLDER')" - @blur="$v.automation.name.$touch" />
-
@@ -86,7 +86,7 @@