feat: invalidate cache after inbox members or team members update (#10869)
At the moment, when updating the inbox members, or team members the account cache used for IndexedDB is not invalidated. This can cause inconsistencies in the UI. This PR fixes this by adding explicit invalidation after performing the member changes ### Summary of changes 1. Added a new method `add_members` and `remove_members` to both `team` and `inbox` models. The change was necessary for two reasons - Since the individual `add_member` and `remove_member` is called in a loop, it's wasteful to run the cache invalidation in the method. - Moving the account cache invalidation call in the controller pollutes the controller business logic 2. Updated tests across the board ### More improvements We can make a concern called `Memberable` with usage like `memberable_with :inbox_members`, that can encapsulate the functionality --- Related: https://github.com/chatwoot/chatwoot/issues/10578
This commit is contained in:
@@ -82,14 +82,20 @@ class Inbox < ApplicationRecord
|
||||
|
||||
scope :order_by_name, -> { order('lower(name) ASC') }
|
||||
|
||||
def add_member(user_id)
|
||||
member = inbox_members.new(user_id: user_id)
|
||||
member.save!
|
||||
# Adds multiple members to the inbox
|
||||
# @param user_ids [Array<Integer>] Array of user IDs to add as members
|
||||
# @return [void]
|
||||
def add_members(user_ids)
|
||||
inbox_members.create!(user_ids.map { |user_id| { user_id: user_id } })
|
||||
update_account_cache
|
||||
end
|
||||
|
||||
def remove_member(user_id)
|
||||
member = inbox_members.find_by!(user_id: user_id)
|
||||
member.try(:destroy)
|
||||
# Removes multiple members from the inbox
|
||||
# @param user_ids [Array<Integer>] Array of user IDs to remove
|
||||
# @return [void]
|
||||
def remove_members(user_ids)
|
||||
inbox_members.where(user_id: user_ids).destroy_all
|
||||
update_account_cache
|
||||
end
|
||||
|
||||
def facebook?
|
||||
|
||||
@@ -31,12 +31,24 @@ class Team < ApplicationRecord
|
||||
self.name = name.downcase if attribute_present?('name')
|
||||
end
|
||||
|
||||
def add_member(user_id)
|
||||
team_members.find_or_create_by(user_id: user_id)&.user
|
||||
# Adds multiple members to the team
|
||||
# @param user_ids [Array<Integer>] Array of user IDs to add as members
|
||||
# @return [Array<User>] Array of newly added members
|
||||
def add_members(user_ids)
|
||||
team_members_to_create = user_ids.map { |user_id| { user_id: user_id } }
|
||||
created_members = team_members.create(team_members_to_create)
|
||||
added_users = created_members.filter_map(&:user)
|
||||
|
||||
update_account_cache
|
||||
added_users
|
||||
end
|
||||
|
||||
def remove_member(user_id)
|
||||
team_members.find_by(user_id: user_id)&.destroy!
|
||||
# Removes multiple members from the team
|
||||
# @param user_ids [Array<Integer>] Array of user IDs to remove
|
||||
# @return [void]
|
||||
def remove_members(user_ids)
|
||||
team_members.where(user_id: user_ids).destroy_all
|
||||
update_account_cache
|
||||
end
|
||||
|
||||
def messages
|
||||
|
||||
Reference in New Issue
Block a user