From c00855fce42b9ce28a4a16881ec51526d788eaa3 Mon Sep 17 00:00:00 2001 From: Tejaswini Chile Date: Thu, 27 Jul 2023 12:11:48 +0530 Subject: [PATCH] fix: Skip sentiment analysis for blank text (#7580) Co-authored-by: Sojan Jose --- enterprise/app/jobs/enterprise/sentiment_analysis_job.rb | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/enterprise/app/jobs/enterprise/sentiment_analysis_job.rb b/enterprise/app/jobs/enterprise/sentiment_analysis_job.rb index 379693e89..e85a89ed8 100644 --- a/enterprise/app/jobs/enterprise/sentiment_analysis_job.rb +++ b/enterprise/app/jobs/enterprise/sentiment_analysis_job.rb @@ -2,8 +2,7 @@ class Enterprise::SentimentAnalysisJob < ApplicationJob queue_as :low def perform(message) - return if message.account.locale != 'en' - return if valid_incoming_message?(message) + return if message.account.locale != 'en' || !valid_incoming_message?(message) save_message_sentiment(message) rescue StandardError => e @@ -39,7 +38,7 @@ class Enterprise::SentimentAnalysisJob < ApplicationJob end def valid_incoming_message?(message) - !message.incoming? || message.private? + message.incoming? && message.content.present? && !message.private? end # returns the sentiment file from vendor folder else download it to the path from AWS-S3