LeadMagnet/leadchat
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

fix: Change the message status to failed if the Twilio message delivery status is undelivered (#8097)

Browse Source
This commit is contained in:
Muhsin Keloth
2023-10-12 15:27:38 +05:30
committed by GitHub
parent 7c9884b853
commit bd918ee506
2 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
spec/services/twilio/delivery_status_service_spec.rb
View File

@@ -59,21 +59,24 @@ describe Twilio::DeliveryStatusService do
expect(conversation.reload.messages.last.status).to eq('sent')
end
it 'updates message status to failed if message status is failed' do
it 'updates message status to failed if message status is undelivered' do
params = {
SmsSid: 'SMxx',
From: '+12345',
AccountSid: 'ACxxx',
MessagingServiceSid: twilio_channel.messaging_service_sid,
MessageSid: conversation.messages.last.source_id,
MessageStatus: 'failed'
MessageStatus: 'undelivered',
ErrorCode: '30002',
ErrorMessage: 'Account suspended'
}
described_class.new(params: params).perform
expect(conversation.reload.messages.last.status).to eq('failed')
expect(conversation.reload.messages.last.external_error).to eq('30002 - Account suspended')
end
it 'updates message status to failed and updates the error message if message status is undelivered' do
it 'updates message status to failed and updates the error message if message status is failed' do
params = {
SmsSid: 'SMxx',
From: '+12345',