fix: Update associations when a label is updated (#3046)

spec/jobs/labels/update_job_spec.rb

@@ -0,0 +1,15 @@
+require 'rails_helper'
+
+RSpec.describe Labels::UpdateJob, type: :job do
+  subject(:job) { described_class.perform_later(new_label_title, old_label_title, account_id) }
+
+  let(:new_label_title) { 'new-title' }
+  let(:old_label_title) { 'old-title' }
+  let(:account_id) { 1 }
+
+  it 'queues the job' do
+    expect { job }.to have_enqueued_job(described_class)
+      .with(new_label_title, old_label_title, account_id)
+      .on_queue('default')
+  end
+end

spec/models/label_spec.rb

@@ -39,4 +39,20 @@ RSpec.describe Label, type: :model do
       expect(duplicate_label.valid?).to eq false
     end
   end
+
+  describe '.after_update_commit' do
+    let(:label) { create(:label) }
+
+    it 'calls update job' do
+      expect(Labels::UpdateJob).to receive(:perform_later).with('new-title', label.title, label.account_id)
+
+      label.update(title: 'new-title')
+    end
+
+    it 'does not call update job if title is not updated' do
+      expect(Labels::UpdateJob).not_to receive(:perform_later)
+
+      label.update(description: 'new-description')
+    end
+  end
 end

spec/services/labels/update_service_spec.rb

@@ -0,0 +1,32 @@
+require 'rails_helper'
+
+describe Labels::UpdateService do
+  let(:account) { create(:account) }
+  let(:conversation) { create(:conversation, account: account) }
+  let(:label) { create(:label, account: account) }
+  let(:contact) { conversation.contact }
+
+  before do
+    conversation.label_list.add(label.title)
+    conversation.save!
+
+    contact.label_list.add(label.title)
+    contact.save!
+  end
+
+  describe '#perform' do
+    it 'updates associated conversations/contacts labels' do
+      expect(conversation.label_list).to eq([label.title])
+      expect(contact.label_list).to eq([label.title])
+
+      described_class.new(
+        new_label_title: 'updated-label-title',
+        old_label_title: label.title,
+        account_id: account.id
+      ).perform
+
+      expect(conversation.reload.label_list).to eq(['updated-label-title'])
+      expect(contact.reload.label_list).to eq(['updated-label-title'])
+    end
+  end
+end