LeadMagnet/leadchat
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

fix: Handle empty status in conversation controller (#8091)

Browse Source 
Fixes CW-2644
This commit is contained in:
Vishnu Narayanan
2023-10-12 17:11:04 +05:30
committed by GitHub
parent 415bb23c37
commit ae52ca87aa
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/controllers/api/v1/accounts/conversations_controller.rb
View File

@@ -60,7 +60,7 @@ class Api::V1::Accounts::ConversationsController < Api::V1::Accounts::BaseContro
end end
def toggle_status def toggle_status
if params[:status] if params[:status].present?
set_conversation_status set_conversation_status
@status = @conversation.save! @status = @conversation.save!
else else

3
spec/controllers/api/v1/accounts/conversations_controller_spec.rb
View File

@@ -340,11 +340,12 @@ RSpec.describe 'Conversations API', type: :request do
create(:inbox_member, user: agent, inbox: conversation.inbox) create(:inbox_member, user: agent, inbox: conversation.inbox)
end end
it 'toggles the conversation status' do it 'toggles the conversation status if status is empty' do
expect(conversation.status).to eq('open') expect(conversation.status).to eq('open')
post "/api/v1/accounts/#{account.id}/conversations/#{conversation.display_id}/toggle_status", post "/api/v1/accounts/#{account.id}/conversations/#{conversation.display_id}/toggle_status",
headers: agent.create_new_auth_token, headers: agent.create_new_auth_token,
params: { status: '' },
as: :json as: :json
expect(response).to have_http_status(:success) expect(response).to have_http_status(:success)