Sprinkle frozen string literal & Indentation Fix (#150)

* Avoid extra string alocation as join will always return string

* Fix indentation

* Sprinkle frozen string literal true

app/builders/account_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class AccountBuilder
   include CustomExceptions::Account
 
@@ -59,7 +61,6 @@ class AccountBuilder
     else
       raise UserErrors.new({errors: @user.errors})
     end
-
   end
 
   def email_to_name(email)
@@ -67,5 +68,4 @@ class AccountBuilder
     name.split(".").map {|n| n.capitalize }.join(" ")
   end
 
-
 end

app/controllers/application_controller.rb

@@ -58,7 +58,7 @@ class ApplicationController < ActionController::Base
 
   def render_record_invalid(exception)
      render json: {
-      message: "#{exception.record.errors.full_messages.join(", ")}"
+      message: exception.record.errors.full_messages.join(", ")
     }, status: :unprocessable_entity
   end
 

app/controllers/confirmations_controller.rb

@@ -2,7 +2,6 @@ class ConfirmationsController < Devise::ConfirmationsController
   skip_before_action :require_no_authentication, raise: false
   skip_before_action :authenticate_user!, raise: false
 
-
   def create
     begin
       @confirmable = User.find_by(confirmation_token: params[:confirmation_token])

lib/constants/report.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Constants::Report
   ACCOUNT_METRICS = [ :conversations_count,
                       :incoming_messages_count,

lib/custom_exceptions/account.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module CustomExceptions::Account
 
   class InvalidEmail < CustomExceptions::Base

lib/custom_exceptions/base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CustomExceptions::Base < ::StandardError
 
   def to_hash

lib/custom_exceptions/report.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module CustomExceptions::Report
   class InvalidIdentity < CustomExceptions::Base
     def message

lib/events/types.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Events::Types
   CONVERSATION_CREATED = 'conversation.created'
   CONVERSATION_RESOLVED = 'conversation.resolved'

lib/integrations/facebook/delivery_status.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Integrations::Facebook::DeliveryStatus
 
   def initialize(params)

lib/integrations/facebook/message_creator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Integrations::Facebook::MessageCreator
 
   attr_reader :response
@@ -28,8 +30,8 @@ class Integrations::Facebook::MessageCreator
 
   def create_outgoing_message
     FacebookPage.where(page_id: response.sender_id).each do |page|
-        mb = Messages::Outgoing::EchoBuilder.new(response, page.inbox, true)
+      mb = Messages::Outgoing::EchoBuilder.new(response, page.inbox, true)
-        mb.perform
+      mb.perform
     end
   end
 

lib/integrations/facebook/message_parser.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Integrations::Facebook::MessageParser
 
   def initialize(response_json)

lib/integrations/widget/incoming_message_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Integrations::Widget::IncomingMessageBuilder
   #  params = {
   #   contact_id: 1,

lib/integrations/widget/outgoing_message_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Integrations::Widget::OutgoingMessageBuilder
   # params = {
   #   user_id: 1,

lib/local_resource.rb

@@ -1,38 +1,38 @@
 class LocalResource
- attr_reader :uri
+  attr_reader :uri
 
- def initialize(uri)
+  def initialize(uri)
- @uri = uri
+    @uri = uri
- end
+  end
 
- def file
+  def file
- @file ||= Tempfile.new(tmp_filename, tmp_folder, encoding: encoding).tap do |f|
+    @file ||= Tempfile.new(tmp_filename, tmp_folder, encoding: encoding).tap do |f|
- io.rewind
+      io.rewind
- f.write(io.read)
+      f.write(io.read)
- f.close
+      f.close
- end
+    end
- end
+  end
 
- def io
+  def io
- @io ||= uri.open
+    @io ||= uri.open
- end
+  end
 
- def encoding
+  def encoding
- io.rewind
+    io.rewind
- io.read.encoding
+    io.read.encoding
- end
+  end
 
- def tmp_filename
+  def tmp_filename
- [
+    [
- Time.now.to_i.to_s,
+      Time.now.to_i.to_s,
- Pathname.new(uri.path).extname
+      Pathname.new(uri.path).extname
- ]
+    ]
- end
+  end
 
- def tmp_folder
+  def tmp_folder
- # If we're using Rails:
+    # If we're using Rails:
- Rails.root.join('tmp')
+    Rails.root.join('tmp')
- # Otherwise:
+    # Otherwise:
- # '/wherever/you/want'
+    # '/wherever/you/want'
- end
+  end
 end

lib/reports/update_account_identity.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Reports::UpdateAccountIdentity < Reports::UpdateIdentity
   attr_reader :account
 

lib/reports/update_agent_identity.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Reports::UpdateAgentIdentity < Reports::UpdateIdentity
   attr_reader :agent
 

lib/reports/update_identity.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Reports::UpdateIdentity
 
   attr_reader :account, :identity

lib/webhooks/chargebee.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Webhooks::Chargebee
 
   SUPPORTED_EVENTS = [:subscription_created, :subscription_trial_end_reminder,