fix: undefined method contact in support mailbox (#2678)
if chatwoot receives an email of already existing contact with a different case say "Care@example.com", before this fix, it will throw an error. Now it will retrieve existing contact Fixes: #2553 Co-authored-by: Sojan Jose <sojan@pepalo.com>
This commit is contained in:
@@ -66,6 +66,20 @@ describe ::ContactBuilder do
|
||||
expect(contact_inbox.contact.id).to be(contact.id)
|
||||
end
|
||||
|
||||
it 'doesnot create contact when an uppercase email is passed for an already existing contact email' do
|
||||
contact_inbox = described_class.new(
|
||||
source_id: '123456',
|
||||
inbox: inbox,
|
||||
contact_attributes: {
|
||||
name: 'Contact',
|
||||
phone_number: '+1234567890',
|
||||
email: contact.email.upcase
|
||||
}
|
||||
).perform
|
||||
|
||||
expect(contact_inbox.contact.id).to be(contact.id)
|
||||
end
|
||||
|
||||
it 'doesnot create contact if it already exist with phone number' do
|
||||
contact_inbox = described_class.new(
|
||||
source_id: '123456',
|
||||
|
||||
4
spec/fixtures/files/welcome.eml
vendored
4
spec/fixtures/files/welcome.eml
vendored
@@ -1,4 +1,4 @@
|
||||
From: Sony Mathew <sony@chatwoot.com>
|
||||
From: Sony Mathew <Sony@chatwoot.com>
|
||||
Mime-Version: 1.0 (Apple Message framework v1244.3)
|
||||
Content-Type: multipart/alternative; boundary="Apple-Mail=_33A037C7-4BB3-4772-AE52-FCF2D7535F74"
|
||||
Subject: Discussion: Let's debate these attachments
|
||||
@@ -628,4 +628,4 @@ r/Fxp3Y0d2/4tvsR95f/AAH7Gvwmn9rUHsOgUCg//9k=
|
||||
|
||||
--Apple-Mail=_83444AF4-343C-4F75-AF8F-14E1E7434FC1--
|
||||
|
||||
--Apple-Mail=_33A037C7-4BB3-4772-AE52-FCF2D7535F74--
|
||||
--Apple-Mail=_33A037C7-4BB3-4772-AE52-FCF2D7535F74--
|
||||
|
||||
@@ -52,5 +52,9 @@ RSpec.describe MailPresenter do
|
||||
expect(data[:multipart]).to eq(true)
|
||||
expect(data[:subject]).to eq(decorated_mail.subject)
|
||||
end
|
||||
|
||||
it 'give email from in downcased format' do
|
||||
expect(decorated_mail.from.first.eql?(mail.from.first.downcase)).to eq true
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user