LeadMagnet/leadchat
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

fix: Return 404 if conversation is nil (#8098)

Browse Source
This commit is contained in:
Pranav Raj S
2023-10-12 04:30:51 -07:00
committed by GitHub
parent bd918ee506
commit 9e173fca3c
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/controllers/api/v1/widget/conversations_controller.rb
View File

@@ -1,5 +1,6 @@
class Api::V1::Widget::ConversationsController < Api::V1::Widget::BaseController class Api::V1::Widget::ConversationsController < Api::V1::Widget::BaseController
include Events::Types include Events::Types
before_action :render_not_found_if_empty, only: [:toggle_typing, :toggle_status, :set_custom_attributes, :destroy_custom_attributes]
def index def index
@conversation = conversation @conversation = conversation
@@ -41,8 +42,6 @@ class Api::V1::Widget::ConversationsController < Api::V1::Widget::BaseController
end end
def toggle_typing def toggle_typing
head :ok && return if conversation.nil?
case permitted_params[:typing_status] case permitted_params[:typing_status]
when 'on' when 'on'
trigger_typing_event(CONVERSATION_TYPING_ON) trigger_typing_event(CONVERSATION_TYPING_ON)
@@ -54,8 +53,6 @@ class Api::V1::Widget::ConversationsController < Api::V1::Widget::BaseController
end end
def toggle_status def toggle_status
return head :not_found if conversation.nil?
return head :forbidden unless @web_widget.end_conversation? return head :forbidden unless @web_widget.end_conversation?
unless conversation.resolved? unless conversation.resolved?
@@ -81,6 +78,10 @@ class Api::V1::Widget::ConversationsController < Api::V1::Widget::BaseController
Rails.configuration.dispatcher.dispatch(event, Time.zone.now, conversation: conversation, user: @contact) Rails.configuration.dispatcher.dispatch(event, Time.zone.now, conversation: conversation, user: @contact)
end end
def render_not_found_if_empty
return head :not_found if conversation.nil?
end
def permitted_params def permitted_params
params.permit(:id, :typing_status, :website_token, :email, contact: [:name, :email, :phone_number], params.permit(:id, :typing_status, :website_token, :email, contact: [:name, :email, :phone_number],
message: [:content, :referer_url, :timestamp, :echo_id], message: [:content, :referer_url, :timestamp, :echo_id],