feat: Update the slack integration-flow to allow users to select the channel (#7637)

spec/jobs/hook_job_spec.rb

@@ -15,6 +15,20 @@ RSpec.describe HookJob do
       .on_queue('medium')
   end
 
+  context 'when the hook is disabled' do
+    it 'does not execute the job' do
+      hook = create(:integrations_hook, status: 'disabled', account: account)
+      allow(SendOnSlackJob).to receive(:perform_later)
+      allow(Integrations::Dialogflow::ProcessorService).to receive(:new)
+      allow(Integrations::GoogleTranslate::DetectLanguageService).to receive(:new)
+
+      expect(SendOnSlackJob).not_to receive(:perform_later)
+      expect(Integrations::GoogleTranslate::DetectLanguageService).not_to receive(:new)
+      expect(Integrations::Dialogflow::ProcessorService).not_to receive(:new)
+      described_class.perform_now(hook, event_name, event_data)
+    end
+  end
+
   context 'when handleable events like message.created' do
     let(:process_service) { double }
 

spec/requests/api/v1/accounts/integrations/slack_request_spec.rb

@@ -2,7 +2,7 @@ require 'rails_helper'
 
 RSpec.describe 'Api::V1::Accounts::Integrations::Slacks' do
   let(:account) { create(:account) }
-  let(:agent) { create(:user, account: account, role: :administrator) }
+  let(:admin) { create(:user, account: account, role: :administrator) }
   let!(:hook) { create(:integrations_hook, account: account) }
 
   describe 'POST /api/v1/accounts/{account.id}/integrations/slack' do
@@ -15,65 +15,99 @@ RSpec.describe 'Api::V1::Accounts::Integrations::Slacks' do
 
     context 'when it is an authenticated user' do
       it 'creates hook' do
-        hook_builder = Integrations::Slack::HookBuilder.new(account: account, code: SecureRandom.hex)
+        hook_builder = double
         expect(hook_builder).to receive(:perform).and_return(hook)
         expect(Integrations::Slack::HookBuilder).to receive(:new).and_return(hook_builder)
 
-        channel_builder = Integrations::Slack::ChannelBuilder.new(hook: hook, channel: 'channel')
-        expect(channel_builder).to receive(:perform)
-        expect(Integrations::Slack::ChannelBuilder).to receive(:new).and_return(channel_builder)
-
         post "/api/v1/accounts/#{account.id}/integrations/slack",
              params: { code: SecureRandom.hex },
-             headers: agent.create_new_auth_token
+             headers: admin.create_new_auth_token
 
         expect(response).to have_http_status(:success)
         json_response = response.parsed_body
         expect(json_response['id']).to eql('slack')
       end
     end
+  end
 
-    describe 'PUT /api/v1/accounts/{account.id}/integrations/slack/' do
-      context 'when it is an unauthenticated user' do
-        it 'returns unauthorized' do
-          put "/api/v1/accounts/#{account.id}/integrations/slack/", params: {}
-          expect(response).to have_http_status(:unauthorized)
-        end
-      end
-
-      context 'when it is an authenticated user' do
-        it 'updates hook' do
-          channel_builder = Integrations::Slack::ChannelBuilder.new(hook: hook, channel: 'channel')
-          expect(channel_builder).to receive(:perform)
-
-          expect(Integrations::Slack::ChannelBuilder).to receive(:new).and_return(channel_builder)
-
-          put "/api/v1/accounts/#{account.id}/integrations/slack",
-              params: { channel: SecureRandom.hex },
-              headers: agent.create_new_auth_token
-
-          expect(response).to have_http_status(:success)
-          json_response = response.parsed_body
-          expect(json_response['app_id']).to eql('slack')
-        end
+  describe 'PUT /api/v1/accounts/{account.id}/integrations/slack/' do
+    context 'when it is an unauthenticated user' do
+      it 'returns unauthorized' do
+        put "/api/v1/accounts/#{account.id}/integrations/slack/", params: {}
+        expect(response).to have_http_status(:unauthorized)
       end
     end
 
-    describe 'DELETE /api/v1/accounts/{account.id}/integrations/slack' do
-      context 'when it is an unauthenticated user' do
-        it 'returns unauthorized' do
-          delete "/api/v1/accounts/#{account.id}/integrations/slack", params: {}
-          expect(response).to have_http_status(:unauthorized)
-        end
+    context 'when it is an authenticated user' do
+      it 'updates hook if the channel id is correct' do
+        channel_builder = double
+        expect(channel_builder).to receive(:update).and_return(hook)
+        expect(Integrations::Slack::ChannelBuilder).to receive(:new).and_return(channel_builder)
+
+        put "/api/v1/accounts/#{account.id}/integrations/slack",
+            params: { channel: SecureRandom.hex },
+            headers: admin.create_new_auth_token
+
+        expect(response).to have_http_status(:success)
+        json_response = response.parsed_body
+        expect(json_response['hooks'][0]['id']).to eql(hook.id)
       end
 
-      context 'when it is an authenticated user' do
-        it 'deletes hook' do
-          delete "/api/v1/accounts/#{account.id}/integrations/slack",
-                 headers: agent.create_new_auth_token
-          expect(response).to have_http_status(:success)
-          expect(Integrations::Hook.find_by(id: hook.id)).to be_nil
-        end
+      it 'does not update the hook if the channel id is not correct' do
+        channel_builder = double
+        expect(channel_builder).to receive(:update)
+        expect(Integrations::Slack::ChannelBuilder).to receive(:new).and_return(channel_builder)
+
+        put "/api/v1/accounts/#{account.id}/integrations/slack",
+            params: { channel: SecureRandom.hex },
+            headers: admin.create_new_auth_token
+
+        expect(response).to have_http_status(:unprocessable_entity)
+        json_response = response.parsed_body
+        expect(json_response['error']).to eql('Invalid slack channel. Please try again')
+      end
+    end
+  end
+
+  describe 'GET /api/v1/accounts/{account.id}/integrations/slack/list_all_channels' do
+    context 'when it is an unauthenticated user' do
+      it 'returns unauthorized' do
+        get "/api/v1/accounts/#{account.id}/integrations/slack/list_all_channels", params: {}
+        expect(response).to have_http_status(:unauthorized)
+      end
+    end
+
+    context 'when it is an authenticated user' do
+      it 'updates hook if the channel id is correct' do
+        channel_builder = double
+        expect(channel_builder).to receive(:fetch_channels).and_return([{ 'id' => '1', 'name' => 'channel-1' }])
+        expect(Integrations::Slack::ChannelBuilder).to receive(:new).and_return(channel_builder)
+
+        get "/api/v1/accounts/#{account.id}/integrations/slack/list_all_channels",
+            params: { channel: SecureRandom.hex },
+            headers: admin.create_new_auth_token
+
+        expect(response).to have_http_status(:success)
+        json_response = response.parsed_body
+        expect(json_response).to eql([{ 'id' => '1', 'name' => 'channel-1' }])
+      end
+    end
+  end
+
+  describe 'DELETE /api/v1/accounts/{account.id}/integrations/slack' do
+    context 'when it is an unauthenticated user' do
+      it 'returns unauthorized' do
+        delete "/api/v1/accounts/#{account.id}/integrations/slack", params: {}
+        expect(response).to have_http_status(:unauthorized)
+      end
+    end
+
+    context 'when it is an authenticated user' do
+      it 'deletes hook' do
+        delete "/api/v1/accounts/#{account.id}/integrations/slack",
+               headers: admin.create_new_auth_token
+        expect(response).to have_http_status(:success)
+        expect(Integrations::Hook.find_by(id: hook.id)).to be_nil
       end
     end
   end