fix: Exclude notifications for blocked contacts, except mentions (#10659)
- Prevents notifications from being created for conversations or actions involving blocked contacts. - The exception is the conversation_mention notification type, which will still be created when applicable.
This commit is contained in:
@@ -56,7 +56,7 @@ describe NotificationBuilder do
|
||||
).to be_nil
|
||||
end
|
||||
|
||||
it 'will create a conversation_mention notification eventhough user is not subscribed to it' do
|
||||
it 'will create a conversation_mention notification even though user is not subscribed to it' do
|
||||
notification_setting = user.notification_settings.find_by(account_id: account.id)
|
||||
notification_setting.selected_email_flags = []
|
||||
notification_setting.selected_push_flags = []
|
||||
@@ -71,5 +71,31 @@ describe NotificationBuilder do
|
||||
).perform
|
||||
end.to change { user.notifications.count }.by(1)
|
||||
end
|
||||
|
||||
it 'will not create a notification if conversation contact is blocked and notification type is not conversation_mention' do
|
||||
primary_actor.contact.update(blocked: true)
|
||||
|
||||
expect do
|
||||
described_class.new(
|
||||
notification_type: 'conversation_creation',
|
||||
user: user,
|
||||
account: account,
|
||||
primary_actor: primary_actor
|
||||
).perform
|
||||
end.not_to(change { user.notifications.count })
|
||||
end
|
||||
|
||||
it 'will create a notification if conversation contact is blocked and notification type is conversation_mention' do
|
||||
primary_actor.contact.update(blocked: true)
|
||||
|
||||
expect do
|
||||
described_class.new(
|
||||
notification_type: 'conversation_mention',
|
||||
user: user,
|
||||
account: account,
|
||||
primary_actor: primary_actor
|
||||
).perform
|
||||
end.to change { user.notifications.count }.by(1)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user