Date: Fri, 18 Oct 2024 15:59:21 +0530
Subject: [PATCH 03/39] fix: solid colors (#10321)
Fix mismatch in CSS vars for `amber` and `blue` solid colors
---
app/javascript/dashboard/assets/scss/_woot.scss | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/app/javascript/dashboard/assets/scss/_woot.scss b/app/javascript/dashboard/assets/scss/_woot.scss
index 4f59b592c..8afefe384 100644
--- a/app/javascript/dashboard/assets/scss/_woot.scss
+++ b/app/javascript/dashboard/assets/scss/_woot.scss
@@ -108,11 +108,11 @@
--solid-2: 252 252 252;
--solid-3: 255 255 255;
--solid-active: 250 251 251;
+ --solid-amber: 252 232 193;
+ --solid-blue: 218 236 255;
--white-alpha: 255 255 255 0.1;
--border-weak: 231 231 231;
--border-strong: 235 235 235;
- --amber-solid: 252 232 193;
- --blue-solid: 218 236 255;
--blue: 39 129 246;
/* alpha is added by default */
@@ -181,11 +181,11 @@
--solid-1: 23 23 26;
--solid-2: 29 30 36;
--solid-3: 36 38 48;
+ --solid-amber: 42 37 30;
+ --solid-blue: 16 49 91;
--solid-active: 51 53 64;
--border-weak: 34 34 37;
--border-strong: 46 47 49;
- --amber-solid: 42 37 30;
- --blue-solid: 16 49 91;
--blue: 126 182 255;
/* alpha is added by default */
From 3fe771df6f27a1dd4c321b8c048936fc9f226d61 Mon Sep 17 00:00:00 2001
From: Sivin Varghese <64252451+iamsivin@users.noreply.github.com>
Date: Tue, 22 Oct 2024 13:26:56 +0530
Subject: [PATCH 04/39] fix: Modal in the context menu disappears unless
hovered (#10333)
# Pull Request Template
## Description
This PR resolves the issue where the modal in the context menu
disappears when not being hovered over.
**Cause of issue.**
The problem occurred because the modal-related component was placed
inside `MessageContextMenu.vue`, and the parent wrapper was using the
classes `group-hover:visible invisible`. This caused the modal to only
appear when the message item, where the context menu was opened, was
hovered over.
**Solution**
To fix this, I removed the `group-hover:visible` invisible class from
the parent wrapper and moved it into the `woot-button` within the
`MessageContextMenu.vue` component. Additionally, I added a nested group
with the class group/context-menu, allowing the focus to remain on the
context menu itself.
Fixes
https://linear.app/chatwoot/issue/PR-1415/modal-in-the-context-menu-disappears-unless-hovered
## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
## How Has This Been Tested?
**Loom video**
**Before**
https://www.loom.com/share/458f90708664493c86e909a56869d065?sid=0564a508-09a5-4e73-800b-8042140a22ba
**After**
https://www.loom.com/share/c119936d181d406d89468f9482ef6b81?sid=5cf3b1b4-6c66-4f8c-8f93-a62465a93b57
## Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my code
- [ ] I have commented on my code, particularly in hard-to-understand
areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream
modules
---
.../dashboard/components/widgets/conversation/Message.vue | 7 ++-----
.../conversations/components/MessageContextMenu.vue | 1 +
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/app/javascript/dashboard/components/widgets/conversation/Message.vue b/app/javascript/dashboard/components/widgets/conversation/Message.vue
index 06124270e..0cccde65a 100644
--- a/app/javascript/dashboard/components/widgets/conversation/Message.vue
+++ b/app/javascript/dashboard/components/widgets/conversation/Message.vue
@@ -444,7 +444,7 @@ export default {
@@ -568,10 +568,7 @@ export default {
-