LeadMagnet/leadchat
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

feat(perf): improve performance of conversation filter API [CW-1605] (#7120)

Browse Source 
* feat(perf): don't use count

* feat(perf): include messages in the conversation query

* feat: include contact inboxes

* refactor: use blank?
This commit is contained in:
Shivam Mishra
2023-05-22 16:03:11 +05:30
committed by GitHub
parent 9553329092
commit 958c0d7946
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/services/conversations/filter_service.rb
View File

@@ -58,8 +58,9 @@ class Conversations::FilterService < FilterService
def conversations def conversations
@conversations = @conversations.includes( @conversations = @conversations.includes(
:taggings, :inbox, { assignee: { avatar_attachment: [:blob] } }, { contact: { avatar_attachment: [:blob] } }, :team :taggings, :inbox, { assignee: { avatar_attachment: [:blob] } }, { contact: { avatar_attachment: [:blob] } }, :team, :messages, :contact_inbox
) )
@conversations.latest.page(current_page) @conversations.latest.page(current_page)
end end
end end

2
app/views/api/v1/conversations/partials/_conversation.json.jbuilder
View File

@@ -17,7 +17,7 @@ json.meta do
end end
json.id conversation.display_id json.id conversation.display_id
if conversation.messages.count.zero? if conversation.messages.first.blank?
json.messages [] json.messages []
elsif conversation.unread_incoming_messages.count.zero? elsif conversation.unread_incoming_messages.count.zero?
json.messages [conversation.messages.includes([{ attachments: [{ file_attachment: [:blob] }] }]).last.try(:push_event_data)] json.messages [conversation.messages.includes([{ attachments: [{ file_attachment: [:blob] }] }]).last.try(:push_event_data)]