chore: Get all notification API improvments (#8549)

Co-authored-by: Sojan Jose <sojan@chatwoot.com>

spec/builders/notification_builder_spec.rb

@@ -11,6 +11,7 @@ describe NotificationBuilder do
     before do
       notification_setting = user.notification_settings.find_by(account_id: account.id)
       notification_setting.selected_email_flags = [:email_conversation_creation]
+      notification_setting.selected_push_flags = [:push_conversation_creation]
       notification_setting.save!
     end
 
@@ -38,5 +39,37 @@ describe NotificationBuilder do
         ).perform
       ).to be_nil
     end
+
+    it 'will not create a conversation_creation notification if user is not subscribed to it' do
+      notification_setting = user.notification_settings.find_by(account_id: account.id)
+      notification_setting.selected_email_flags = []
+      notification_setting.selected_push_flags = []
+      notification_setting.save!
+
+      expect(
+        described_class.new(
+          notification_type: 'conversation_creation',
+          user: user,
+          account: account,
+          primary_actor: primary_actor
+        ).perform
+      ).to be_nil
+    end
+
+    it 'will create a conversation_mention notification eventhough user is not subscribed to it' do
+      notification_setting = user.notification_settings.find_by(account_id: account.id)
+      notification_setting.selected_email_flags = []
+      notification_setting.selected_push_flags = []
+      notification_setting.save!
+
+      expect do
+        described_class.new(
+          notification_type: 'conversation_mention',
+          user: user,
+          account: account,
+          primary_actor: primary_actor
+        ).perform
+      end.to change { user.notifications.count }.by(1)
+    end
   end
 end

spec/finders/notification_finder_spec.rb

@@ -0,0 +1,67 @@
+require 'rails_helper'
+
+describe NotificationFinder do
+  subject(:notification_finder) { described_class.new(user, account, params) }
+
+  let!(:account) { create(:account) }
+  let!(:user) { create(:user, account: account) }
+
+  before do
+    create(:notification, account: account, user: user, updated_at: DateTime.now.utc + 1.day, last_activity_at: DateTime.now.utc + 1.day,
+                          read_at: DateTime.now.utc)
+    create(:notification, account: account, user: user, snoozed_until: DateTime.now.utc + 3.days, updated_at: DateTime.now.utc,
+                          last_activity_at: DateTime.now.utc)
+    create(:notification, account: account, user: user, updated_at: DateTime.now.utc + 2.days, last_activity_at: DateTime.now.utc + 2.days)
+    create(:notification, account: account, user: user, updated_at: DateTime.now.utc + 4.days, last_activity_at: DateTime.now.utc + 4.days,
+                          notification_type: :conversation_creation, read_at: DateTime.now.utc)
+    create(:notification, account: account, user: user, updated_at: DateTime.now.utc + 5.days, last_activity_at: DateTime.now.utc + 5.days,
+                          notification_type: :conversation_mention)
+    create(:notification, account: account, user: user, updated_at: DateTime.now.utc + 6.days, last_activity_at: DateTime.now.utc + 6.days,
+                          notification_type: :participating_conversation_new_message)
+  end
+
+  describe '#perform' do
+    context 'when params are empty' do
+      let(:params) { {} }
+
+      it 'returns all the notifications' do
+        result = notification_finder.perform
+        expect(result.length).to be 6
+      end
+
+      it 'orders notifications by last activity at' do
+        result = notification_finder.perform
+        expect(result.first.last_activity_at).to be > result.last.last_activity_at
+      end
+
+      it 'returns unread count' do
+        result = notification_finder.unread_count
+        expect(result).to be 4
+      end
+
+      it 'returns count' do
+        result = notification_finder.count
+        expect(result).to be 6
+      end
+    end
+
+    context 'when snoozed param is passed' do
+      let(:params) { { status: 'snoozed' } }
+
+      it 'returns only snoozed notifications' do
+        result = notification_finder.perform
+        expect(result.length).to be 1
+      end
+
+      it 'returns unread count' do
+        result = notification_finder.unread_count
+        expect(result).to be 1
+      end
+
+      it 'returns count' do
+        result = notification_finder.count
+        expect(result).to be 1
+      end
+    end
+  end
+end

spec/models/notification_spec.rb

@@ -16,8 +16,8 @@ RSpec.describe Notification do
       create(:notification)
       notification3 = create(:notification)
 
-      expect(described_class.all.first).to eq notification3
-      expect(described_class.all.last).to eq notification1
+      expect(described_class.all.first).to eq notification1
+      expect(described_class.all.last).to eq notification3
     end
   end