LeadMagnet/leadchat
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

chore: Enable the new Rubocop rules (#7122)

Browse Source 
fixes: https://linear.app/chatwoot/issue/CW-1574/renable-the-disabled-rubocop-rules
This commit is contained in:
Sojan Jose
2023-05-19 14:37:10 +05:30
committed by GitHub
parent b988a01df3
commit 7ab7bac6bf
215 changed files with 609 additions and 608 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spec/builders/campaigns/campaign_conversation_builder_spec.rb
View File

@@ -1,6 +1,6 @@
require 'rails_helper'
describe ::Campaigns::CampaignConversationBuilder do
describe Campaigns::CampaignConversationBuilder do
let(:account) { create(:account) }
let(:inbox) { create(:inbox, account: account) }
let(:contact) { create(:contact, account: account, identifier: '123') }

2
spec/builders/contact_inbox_builder_spec.rb
View File

@@ -1,6 +1,6 @@
require 'rails_helper'
describe ::ContactInboxBuilder do
describe ContactInboxBuilder do
let(:account) { create(:account) }
let(:contact) { create(:contact, email: 'xyc@example.com', phone_number: '+23423424123', account: account) }

2
spec/builders/contact_inbox_with_contact_builder_spec.rb
View File

@@ -1,6 +1,6 @@
require 'rails_helper'
describe ::ContactInboxWithContactBuilder do
describe ContactInboxWithContactBuilder do
let(:account) { create(:account) }
let(:inbox) { create(:inbox, account: account) }
let(:contact) { create(:contact, email: 'xyc@example.com', phone_number: '+23423424123', account: account, identifier: '123') }

2
spec/builders/conversation_builder_spec.rb
View File

@@ -1,6 +1,6 @@
require 'rails_helper'
describe ::ConversationBuilder do
describe ConversationBuilder do
let(:account) { create(:account) }
let!(:sms_channel) { create(:channel_sms, account: account) }
let!(:sms_inbox) { create(:inbox, channel: sms_channel, account: account) }

2
spec/builders/csat_surveys/response_builder_spec.rb
View File

@@ -1,6 +1,6 @@
require 'rails_helper'
describe ::CsatSurveys::ResponseBuilder do
describe CsatSurveys::ResponseBuilder do
let(:message) do
create(
:message, content_type: :input_csat,

2
spec/builders/messages/facebook/message_builder_spec.rb
View File

@@ -1,6 +1,6 @@
require 'rails_helper'
describe ::Messages::Facebook::MessageBuilder do
describe Messages::Facebook::MessageBuilder do
subject(:message_builder) { described_class.new(incoming_fb_text_message, facebook_channel.inbox).perform }
before do

2
spec/builders/messages/instagram/message_builder_spec.rb
View File

@@ -1,6 +1,6 @@
require 'rails_helper'
describe ::Messages::Instagram::MessageBuilder do
describe Messages::Instagram::MessageBuilder do
subject(:instagram_message_builder) { described_class }
before do

2
spec/builders/messages/message_builder_spec.rb
View File

@@ -1,6 +1,6 @@
require 'rails_helper'
describe ::Messages::MessageBuilder do
describe Messages::MessageBuilder do
subject(:message_builder) { described_class.new(user, conversation, params).perform }
let(:account) { create(:account) }

2
spec/builders/notification_builder_spec.rb
View File

@@ -1,6 +1,6 @@
require 'rails_helper'
describe ::NotificationBuilder do
describe NotificationBuilder do
include ActiveJob::TestHelper
describe '#perform' do

32
spec/builders/v2/report_builder_spec.rb
View File

@@ -1,6 +1,6 @@
require 'rails_helper'
describe ::V2::ReportBuilder do
describe V2::ReportBuilder do
include ActiveJob::TestHelper
let_it_be(:account) { create(:account) }
let_it_be(:label_1) { create(:label, title: 'Label_1', account: account) }
@@ -60,7 +60,7 @@ describe ::V2::ReportBuilder do
until: Time.zone.today.end_of_day.to_time.to_i.to_s
}
builder = V2::ReportBuilder.new(account, params)
builder = described_class.new(account, params)
metrics = builder.timeseries
expect(metrics[Time.zone.today]).to be 10
@@ -75,7 +75,7 @@ describe ::V2::ReportBuilder do
until: Time.zone.today.end_of_day.to_time.to_i.to_s
}
builder = V2::ReportBuilder.new(account, params)
builder = described_class.new(account, params)
metrics = builder.timeseries
expect(metrics[Time.zone.today]).to be 20
@@ -90,7 +90,7 @@ describe ::V2::ReportBuilder do
until: Time.zone.today.end_of_day.to_time.to_i.to_s
}
builder = V2::ReportBuilder.new(account, params)
builder = described_class.new(account, params)
metrics = builder.timeseries
expect(metrics[Time.zone.today]).to be 50
@@ -107,7 +107,7 @@ describe ::V2::ReportBuilder do
conversations = account.conversations.where('created_at < ?', 1.day.ago)
conversations.each(&:resolved!)
builder = V2::ReportBuilder.new(account, params)
builder = described_class.new(account, params)
metrics = builder.timeseries
expect(metrics[Time.zone.today]).to be 0
@@ -122,7 +122,7 @@ describe ::V2::ReportBuilder do
until: Time.zone.today.end_of_day.to_time.to_i.to_s
}
builder = V2::ReportBuilder.new(account, params)
builder = described_class.new(account, params)
metrics = builder.timeseries
expect(metrics[Time.zone.today].to_f).to be 0.48e4
@@ -135,7 +135,7 @@ describe ::V2::ReportBuilder do
until: Time.zone.today.end_of_day.to_time.to_i.to_s
}
builder = V2::ReportBuilder.new(account, params)
builder = described_class.new(account, params)
metrics = builder.summary
expect(metrics[:conversations_count]).to be 15
@@ -153,7 +153,7 @@ describe ::V2::ReportBuilder do
group_by: 'test'.to_s
}
builder = V2::ReportBuilder.new(account, params)
builder = described_class.new(account, params)
expect { builder.summary }.to raise_error(ArgumentError)
end
end
@@ -168,7 +168,7 @@ describe ::V2::ReportBuilder do
until: Time.zone.today.end_of_day.to_time.to_i.to_s
}
builder = V2::ReportBuilder.new(account, params)
builder = described_class.new(account, params)
metrics = builder.timeseries
expect(metrics[Time.zone.today - 2.days]).to be 5
@@ -183,7 +183,7 @@ describe ::V2::ReportBuilder do
until: (Time.zone.today + 1.day).to_time.to_i.to_s
}
builder = V2::ReportBuilder.new(account, params)
builder = described_class.new(account, params)
metrics = builder.timeseries
expect(metrics[Time.zone.today]).to be 20
@@ -199,7 +199,7 @@ describe ::V2::ReportBuilder do
until: (Time.zone.today + 1.day).to_time.to_i.to_s
}
builder = V2::ReportBuilder.new(account, params)
builder = described_class.new(account, params)
metrics = builder.timeseries
expect(metrics[Time.zone.today]).to be 50
@@ -217,7 +217,7 @@ describe ::V2::ReportBuilder do
conversations = account.conversations.where('created_at < ?', 1.day.ago)
conversations.each(&:resolved!)
builder = V2::ReportBuilder.new(account, params)
builder = described_class.new(account, params)
metrics = builder.timeseries
expect(metrics[Time.zone.today - 2.days]).to be 5
@@ -234,7 +234,7 @@ describe ::V2::ReportBuilder do
until: Time.zone.today.end_of_day.to_time.to_i.to_s
}
builder = V2::ReportBuilder.new(account, params)
builder = described_class.new(account, params)
metrics = builder.timeseries
expect(metrics[Time.zone.today].to_f).to be 0.15e1
end
@@ -247,7 +247,7 @@ describe ::V2::ReportBuilder do
until: Time.zone.today.end_of_day.to_time.to_i.to_s
}
builder = V2::ReportBuilder.new(account, params)
builder = described_class.new(account, params)
metrics = builder.summary
expect(metrics[:conversations_count]).to be 5
@@ -266,7 +266,7 @@ describe ::V2::ReportBuilder do
group_by: 'week'.to_s
}
builder = V2::ReportBuilder.new(account, params)
builder = described_class.new(account, params)
metrics = builder.summary
expect(metrics[:conversations_count]).to be 5
@@ -285,7 +285,7 @@ describe ::V2::ReportBuilder do
group_by: 'test'.to_s
}
builder = V2::ReportBuilder.new(account, params)
builder = described_class.new(account, params)
expect { builder.summary }.to raise_error(ArgumentError)
end
end