From 6c480098f7f4ac0b42e01f691198f2bce2b4ce39 Mon Sep 17 00:00:00 2001 From: Shivam Mishra Date: Thu, 14 Dec 2023 16:18:23 +0530 Subject: [PATCH] chore: log authentication error for FB and Instagram (#8551) --- app/builders/messages/facebook/message_builder.rb | 12 ++++++++++-- app/builders/messages/instagram/message_builder.rb | 4 +++- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/app/builders/messages/facebook/message_builder.rb b/app/builders/messages/facebook/message_builder.rb index 3efb184b9..fec298bce 100644 --- a/app/builders/messages/facebook/message_builder.rb +++ b/app/builders/messages/facebook/message_builder.rb @@ -25,7 +25,9 @@ class Messages::Facebook::MessageBuilder < Messages::Messenger::MessageBuilder build_contact_inbox build_message end - rescue Koala::Facebook::AuthenticationError + rescue Koala::Facebook::AuthenticationError => e + Rails.logger.warn("Facebook authentication error for inbox: #{@inbox.id} with error: #{e.message}") + Rails.logger.error e @inbox.channel.authorization_error! rescue StandardError => e ChatwootExceptionTracker.new(e, account: @inbox.account).capture_exception @@ -108,11 +110,15 @@ class Messages::Facebook::MessageBuilder < Messages::Messenger::MessageBuilder } end + # rubocop:disable Metrics/AbcSize + # rubocop:disable Metrics/MethodLength def contact_params begin k = Koala::Facebook::API.new(@inbox.channel.page_access_token) if @inbox.facebook? result = k.get_object(@sender_id) || {} - rescue Koala::Facebook::AuthenticationError + rescue Koala::Facebook::AuthenticationError => e + Rails.logger.warn("Facebook authentication error for inbox: #{@inbox.id} with error: #{e.message}") + Rails.logger.error e @inbox.channel.authorization_error! raise rescue Koala::Facebook::ClientError => e @@ -130,4 +136,6 @@ class Messages::Facebook::MessageBuilder < Messages::Messenger::MessageBuilder end process_contact_params_result(result) end + # rubocop:enable Metrics/AbcSize + # rubocop:enable Metrics/MethodLength end diff --git a/app/builders/messages/instagram/message_builder.rb b/app/builders/messages/instagram/message_builder.rb index 5b2243906..5610e0671 100644 --- a/app/builders/messages/instagram/message_builder.rb +++ b/app/builders/messages/instagram/message_builder.rb @@ -20,7 +20,9 @@ class Messages::Instagram::MessageBuilder < Messages::Messenger::MessageBuilder ActiveRecord::Base.transaction do build_message end - rescue Koala::Facebook::AuthenticationError + rescue Koala::Facebook::AuthenticationError => e + Rails.logger.warn("Instagram authentication error for inbox: #{@inbox.id} with error: #{e.message}") + Rails.logger.error e @inbox.channel.authorization_error! raise rescue StandardError => e