chore: Persist emojis in Contact Import (#7803)
The previous fix would remove emojis in contact data. This change ensures they are persisited ref: #7787
This commit is contained in:
@@ -27,7 +27,11 @@ class DataImportJob < ApplicationJob
|
|||||||
rejected_contacts = []
|
rejected_contacts = []
|
||||||
# Ensuring that importing non utf-8 characters will not throw error
|
# Ensuring that importing non utf-8 characters will not throw error
|
||||||
data = @data_import.import_file.download
|
data = @data_import.import_file.download
|
||||||
clean_data = data.encode('UTF-8', 'binary', invalid: :replace, undef: :replace, replace: '')
|
utf8_data = data.force_encoding('UTF-8')
|
||||||
|
|
||||||
|
# Ensure that the data is valid UTF-8, preserving valid characters
|
||||||
|
clean_data = utf8_data.valid_encoding? ? utf8_data : utf8_data.encode('UTF-16le', invalid: :replace, replace: '').encode('UTF-8')
|
||||||
|
|
||||||
csv = CSV.parse(clean_data, headers: true)
|
csv = CSV.parse(clean_data, headers: true)
|
||||||
|
|
||||||
csv.each do |row|
|
csv.each do |row|
|
||||||
|
|||||||
2
spec/fixtures/data_import/with_emoji.csv
vendored
Normal file
2
spec/fixtures/data_import/with_emoji.csv
vendored
Normal file
@@ -0,0 +1,2 @@
|
|||||||
|
phone_number,name
|
||||||
|
+123456,T 🏠 🔥 Test
|
||||||
|
@@ -48,6 +48,19 @@ RSpec.describe DataImportJob do
|
|||||||
expect(invalid_data_import.reload.processed_records).to eq(csv_length)
|
expect(invalid_data_import.reload.processed_records).to eq(csv_length)
|
||||||
end
|
end
|
||||||
|
|
||||||
|
it 'will preserve emojis' do
|
||||||
|
data_import = create(:data_import,
|
||||||
|
import_file: Rack::Test::UploadedFile.new(Rails.root.join('spec/fixtures/data_import/with_emoji.csv'),
|
||||||
|
'text/csv'))
|
||||||
|
csv_data = CSV.parse(data_import.import_file.download, headers: true)
|
||||||
|
csv_length = csv_data.length
|
||||||
|
|
||||||
|
described_class.perform_now(data_import)
|
||||||
|
expect(data_import.account.contacts.count).to eq(csv_length)
|
||||||
|
|
||||||
|
expect(data_import.account.contacts.first.name).to eq('T 🏠 🔥 Test')
|
||||||
|
end
|
||||||
|
|
||||||
it 'will not throw error for non utf-8 characters' do
|
it 'will not throw error for non utf-8 characters' do
|
||||||
invalid_data_import = create(:data_import,
|
invalid_data_import = create(:data_import,
|
||||||
import_file: Rack::Test::UploadedFile.new(Rails.root.join('spec/fixtures/data_import/invalid_bytes.csv'),
|
import_file: Rack::Test::UploadedFile.new(Rails.root.join('spec/fixtures/data_import/invalid_bytes.csv'),
|
||||||
|
|||||||
Reference in New Issue
Block a user