LeadMagnet/leadchat
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

chore: Fix twilio inbox create transaction rollback (#9181)

Browse Source 
chore: Fix twilio create transaction
This commit is contained in:
Muhsin Keloth
2024-04-02 15:04:10 +05:30
committed by GitHub
parent 4e28481f27
commit 631598b6b6
1 changed files with 11 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
app/controllers/api/v1/accounts/channels/twilio_channels_controller.rb
View File

@@ -2,13 +2,9 @@ class Api::V1::Accounts::Channels::TwilioChannelsController < Api::V1::Accounts:
before_action :authorize_request before_action :authorize_request
def create def create
ActiveRecord::Base.transaction do process_create
authenticate_twilio rescue StandardError => e
build_inbox render_could_not_create_error(e.message)
setup_webhooks if @twilio_channel.sms?
rescue StandardError => e
render_could_not_create_error(e.message)
end
end end
private private
@@ -17,6 +13,14 @@ class Api::V1::Accounts::Channels::TwilioChannelsController < Api::V1::Accounts:
authorize ::Inbox authorize ::Inbox
end end
def process_create
ActiveRecord::Base.transaction do
authenticate_twilio
build_inbox
setup_webhooks if @twilio_channel.sms?
end
end
def authenticate_twilio def authenticate_twilio
client = if permitted_params[:api_key_sid].present? client = if permitted_params[:api_key_sid].present?
Twilio::REST::Client.new(permitted_params[:api_key_sid], permitted_params[:auth_token], permitted_params[:account_sid]) Twilio::REST::Client.new(permitted_params[:api_key_sid], permitted_params[:auth_token], permitted_params[:account_sid])