LeadMagnet/leadchat
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

fix: Automation Bugs and minor enhancements (#3936)

Browse Source
This commit is contained in:
Fayaz Ahmed
2022-02-15 23:36:29 +05:30
committed by GitHub
parent e345a4486d
commit 5ad6db07b4
17 changed files with 203 additions and 129 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/javascript/dashboard/store/modules/automations.js
View File

@@ -48,7 +48,7 @@ export const actions = {
commit(types.SET_AUTOMATION_UI_FLAG, { isUpdating: true });
try {
const response = await AutomationAPI.update(id, updateObj);
commit(types.EDIT_AUTOMATION, response.data);
commit(types.EDIT_AUTOMATION, response.data.payload);
} catch (error) {
throw new Error(error);
} finally {

4
app/javascript/dashboard/store/modules/specs/automations/actions.spec.js
View File

@@ -50,7 +50,9 @@ describe('#actions', () => {
describe('#update', () => {
it('sends correct actions if API is success', async () => {
axios.patch.mockResolvedValue({ data: automationsList[0] });
axios.patch.mockResolvedValue({
data: { payload: automationsList[0] },
});
await actions.update({ commit }, automationsList[0]);
expect(commit.mock.calls).toEqual([
[types.default.SET_AUTOMATION_UI_FLAG, { isUpdating: true }],

52
app/javascript/dashboard/store/modules/specs/automations/fixtures.js
View File

@@ -1,64 +1,36 @@
export default [
{
id: 12,
name: 'Test 5',
description: 'Hello',
id: 46,
account_id: 1,
name: 'Test',
description: 'This is a test',
event_name: 'conversation_created',
conditions: [
{
values: ['open'],
attribute_key: 'status',
query_operator: null,
filter_operator: 'equal_to',
},
],
actions: [
{
action_name: 'add_label',
action_params: [{}],
},
],
created_on: '2022-01-14T09:17:55.689Z',
actions: [{ action_name: 'add_label', action_params: ['testlabel'] }],
created_on: '2022-02-08T10:46:32.387Z',
active: true,
},
{
id: 13,
id: 47,
account_id: 1,
name: 'Auto resolve conversation',
description: 'Auto resolves conversation',
event_name: 'conversation_updated',
name: 'Snooze',
description: 'Test Description',
event_name: 'conversation_created',
conditions: [
{
values: ['resolved'],
values: ['pending'],
attribute_key: 'status',
query_operator: null,
filter_operator: 'equal_to',
},
],
actions: [
{
action_name: 'add_label',
action_params: [{}],
},
],
created_on: '2022-01-14T13:06:31.843Z',
active: true,
},
{
id: 14,
account_id: 1,
name: 'Fayaz',
description: 'This is a test',
event_name: 'conversation_created',
conditions: {},
actions: [
{
action_name: 'add_label',
action_params: [{}],
},
],
created_on: '2022-01-17T06:46:08.098Z',
actions: [{ action_name: 'assign_team', action_params: [1] }],
created_on: '2022-02-08T11:19:44.714Z',
active: true,
},
];

38
app/javascript/dashboard/store/modules/specs/automations/mutations.spec.js
View File

@@ -18,40 +18,18 @@ describe('#mutations', () => {
});
});
// describe('#EDIT_AUTOMATION', () => {
// it('update automation record', () => {
// const state = { records: [automations[0]] };
// mutations[types.EDIT_AUTOMATION](state, {
// id: 12,
// account_id: 1,
// name: 'Test Automation',
// description: 'This is a test',
// event_name: 'conversation_created',
// conditions: [
// {
// values: ['open'],
// attribute_key: 'status',
// query_operator: null,
// filter_operator: 'equal_to',
// },
// ],
// actions: [
// {
// action_name: 'add_label',
// action_params: [{}],
// },
// ],
// created_on: '2022-01-14T09:17:55.689Z',
// active: true,
// });
// expect(state.records[0].name).toEqual('Test Automation');
// });
// });
describe('#EDIT_AUTOMATION', () => {
it('update automation record', () => {
const state = { records: [automations[0]] };
mutations[types.EDIT_AUTOMATION](state, automations[0]);
expect(state.records[0].name).toEqual('Test 5');
});
});
describe('#DELETE_AUTOMATION', () => {
it('delete automation record', () => {
const state = { records: [automations[0]] };
mutations[types.DELETE_AUTOMATION](state, 12);
mutations[types.DELETE_AUTOMATION](state, 46);
expect(state.records).toEqual([]);
});
});