LeadMagnet/leadchat
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

chore: Use "create!" and "save!" bang methods when not checking the result (#5358)

Browse Source 
* Use "create!" when not checking for errors on the result
* Use "save!" when not checking the result
This commit is contained in:
Jordan Brough
2022-09-13 08:10:06 -04:00
committed by GitHub
parent 44f498be6d
commit 59b31615ed
30 changed files with 47 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/chatwoot_hub.rb
View File

@@ -7,7 +7,7 @@ class ChatwootHub
def self.installation_identifier
identifier = InstallationConfig.find_by(name: 'INSTALLATION_IDENTIFIER')&.value
identifier ||= InstallationConfig.create(name: 'INSTALLATION_IDENTIFIER', value: SecureRandom.uuid).value
identifier ||= InstallationConfig.create!(name: 'INSTALLATION_IDENTIFIER', value: SecureRandom.uuid).value
identifier
end

4
lib/integrations/csml/processor_service.rb
View File

@@ -84,7 +84,7 @@ class Integrations::Csml::ProcessorService < Integrations::BotProcessorService
end
def process_text_messages(message_payload, conversation)
conversation.messages.create(
conversation.messages.create!(
{
message_type: :outgoing,
account_id: conversation.account_id,
@@ -99,7 +99,7 @@ class Integrations::Csml::ProcessorService < Integrations::BotProcessorService
buttons = message_payload['content']['buttons'].map do |button|
{ title: button['content']['title'], value: button['content']['payload'] }
end
conversation.messages.create(
conversation.messages.create!(
{
message_type: :outgoing,
account_id: conversation.account_id,

10
lib/integrations/dialogflow/processor_service.rb
View File

@@ -43,10 +43,10 @@ class Integrations::Dialogflow::ProcessorService < Integrations::BotProcessorSer
return if content_params.blank?
conversation = message.conversation
conversation.messages.create(content_params.merge({
message_type: :outgoing,
account_id: conversation.account_id,
inbox_id: conversation.inbox_id
}))
conversation.messages.create!(content_params.merge({
message_type: :outgoing,
account_id: conversation.account_id,
inbox_id: conversation.inbox_id
}))
end
end

2
lib/integrations/slack/incoming_message_builder.rb
View File

@@ -83,7 +83,7 @@ class Integrations::Slack::IncomingMessageBuilder
def create_message
return unless conversation
@message = conversation.messages.create(
@message = conversation.messages.create!(
message_type: :outgoing,
account_id: conversation.account_id,
inbox_id: conversation.inbox_id,