chore: Use "create!" and "save!" bang methods when not checking the result (#5358)
* Use "create!" when not checking for errors on the result * Use "save!" when not checking the result
This commit is contained in:
@@ -30,7 +30,7 @@ class Line::IncomingMessageService
|
||||
def message_created?(event)
|
||||
return unless event_type_message?(event)
|
||||
|
||||
@message = @conversation.messages.create(
|
||||
@message = @conversation.messages.create!(
|
||||
content: event['message']['text'],
|
||||
account_id: @inbox.account_id,
|
||||
inbox_id: @inbox.id,
|
||||
|
||||
@@ -6,7 +6,7 @@ class Sms::IncomingMessageService
|
||||
def perform
|
||||
set_contact
|
||||
set_conversation
|
||||
@message = @conversation.messages.create(
|
||||
@message = @conversation.messages.create!(
|
||||
content: params[:text],
|
||||
account_id: @inbox.account_id,
|
||||
inbox_id: @inbox.id,
|
||||
|
||||
@@ -12,7 +12,7 @@ class Telegram::IncomingMessageService
|
||||
set_contact
|
||||
update_contact_avatar
|
||||
set_conversation
|
||||
@message = @conversation.messages.create(
|
||||
@message = @conversation.messages.create!(
|
||||
content: params[:message][:text].presence || params[:message][:caption],
|
||||
account_id: @inbox.account_id,
|
||||
inbox_id: @inbox.id,
|
||||
|
||||
@@ -8,7 +8,7 @@ class Twilio::IncomingMessageService
|
||||
|
||||
set_contact
|
||||
set_conversation
|
||||
@message = @conversation.messages.create(
|
||||
@message = @conversation.messages.create!(
|
||||
content: params[:Body],
|
||||
account_id: @inbox.account_id,
|
||||
inbox_id: @inbox.id,
|
||||
|
||||
@@ -7,7 +7,7 @@ class Twitter::DirectMessageParserService < Twitter::WebhooksBaseService
|
||||
set_inbox
|
||||
ensure_contacts
|
||||
set_conversation
|
||||
@message = @conversation.messages.create(
|
||||
@message = @conversation.messages.create!(
|
||||
content: message_create_data['message_data']['text'],
|
||||
account_id: @inbox.account_id,
|
||||
inbox_id: @inbox.id,
|
||||
@@ -30,7 +30,7 @@ class Twitter::DirectMessageParserService < Twitter::WebhooksBaseService
|
||||
def save_media_urls(file)
|
||||
@message.content_attributes[:media_url] = file['media_url']
|
||||
@message.content_attributes[:display_url] = file['display_url']
|
||||
@message.save
|
||||
@message.save!
|
||||
end
|
||||
|
||||
def direct_message_events_params
|
||||
@@ -121,6 +121,6 @@ class Twitter::DirectMessageParserService < Twitter::WebhooksBaseService
|
||||
content_type: media['type']
|
||||
}
|
||||
)
|
||||
@message.save
|
||||
@message.save!
|
||||
end
|
||||
end
|
||||
|
||||
@@ -80,7 +80,7 @@ class Twitter::TweetParserService < Twitter::WebhooksBaseService
|
||||
def create_message
|
||||
find_or_create_contact(user)
|
||||
set_conversation
|
||||
@conversation.messages.create(
|
||||
@conversation.messages.create!(
|
||||
account_id: @inbox.account_id,
|
||||
sender: @contact,
|
||||
content: tweet_text,
|
||||
|
||||
Reference in New Issue
Block a user