chore: Use "create!" and "save!" bang methods when not checking the result (#5358)

* Use "create!" when not checking for errors on the result
* Use "save!" when not checking the result

app/builders/notification_subscription_builder.rb

@@ -25,7 +25,7 @@ class NotificationSubscriptionBuilder
   end
 
   def build_identifier_subscription
-    @identifier_subscription = user.notification_subscriptions.create(params.merge(identifier: identifier))
+    @identifier_subscription = user.notification_subscriptions.create!(params.merge(identifier: identifier))
   end
 
   def update_identifier_subscription

app/controllers/api/v1/accounts/automation_rules_controller.rb

@@ -49,7 +49,7 @@ class Api::V1::Accounts::AutomationRulesController < Api::V1::Accounts::BaseCont
   def clone
     automation_rule = Current.account.automation_rules.find_by(id: params[:automation_rule_id])
     new_rule = automation_rule.dup
-    new_rule.save
+    new_rule.save!
     @automation_rule = new_rule
   end
 

app/controllers/api/v1/accounts/channels/twilio_channels_controller.rb

@@ -44,7 +44,7 @@ class Api::V1::Accounts::Channels::TwilioChannelsController < Api::V1::Accounts:
       phone_number: phone_number,
       medium: medium
     )
-    @inbox = Current.account.inboxes.create(
+    @inbox = Current.account.inboxes.create!(
       name: permitted_params[:name],
       channel: @twilio_channel
     )

app/controllers/api/v1/accounts/contacts_controller.rb

@@ -135,7 +135,7 @@ class Api::V1::Accounts::ContactsController < Api::V1::Accounts::BaseController
 
     inbox = Current.account.inboxes.find(params[:inbox_id])
     source_id = params[:source_id] || SecureRandom.uuid
-    ContactInbox.create(contact: @contact, inbox: inbox, source_id: source_id)
+    ContactInbox.create!(contact: @contact, inbox: inbox, source_id: source_id)
   end
 
   def permitted_params

app/controllers/api/v1/widget/conversations_controller.rb

@@ -9,7 +9,7 @@ class Api::V1::Widget::ConversationsController < Api::V1::Widget::BaseController
     ActiveRecord::Base.transaction do
       process_update_contact
       @conversation = create_conversation
-      conversation.messages.create(message_params)
+      conversation.messages.create!(message_params)
     end
   end
 
@@ -59,7 +59,7 @@ class Api::V1::Widget::ConversationsController < Api::V1::Widget::BaseController
 
     unless conversation.resolved?
       conversation.status = :resolved
-      conversation.save
+      conversation.save!
     end
     head :ok
   end

app/controllers/devise_overrides/sessions_controller.rb

@@ -23,7 +23,7 @@ class DeviseOverrides::SessionsController < ::DeviseTokenAuth::SessionsControlle
 
   def authenticate_resource_with_sso_token
     @token = @resource.create_token
-    @resource.save
+    @resource.save!
 
     sign_in(:user, @resource, store: false, bypass: false)
     # invalidate the token after the user is signed in

app/controllers/twitter/callbacks_controller.rb

@@ -44,12 +44,12 @@ class Twitter::CallbacksController < Twitter::BaseController
   end
 
   def create_inbox
-    twitter_profile = account.twitter_profiles.create(
+    twitter_profile = account.twitter_profiles.create!(
       twitter_access_token: parsed_body['oauth_token'],
       twitter_access_token_secret: parsed_body['oauth_token_secret'],
       profile_id: parsed_body['user_id']
     )
-    account.inboxes.create(
+    account.inboxes.create!(
       name: parsed_body['screen_name'],
       channel: twitter_profile
     )

app/jobs/conversations/activity_message_job.rb

@@ -2,6 +2,6 @@ class Conversations::ActivityMessageJob < ApplicationJob
   queue_as :default
 
   def perform(conversation, message_params)
-    conversation.messages.create(message_params)
+    conversation.messages.create!(message_params)
   end
 end

app/jobs/conversations/user_mention_job.rb

@@ -10,7 +10,7 @@ class Conversations::UserMentionJob < ApplicationJob
       )
 
       if mention.nil?
-        Mention.create(
+        Mention.create!(
           user_id: mentioned_user_id,
           conversation_id: conversation_id,
           mentioned_at: Time.zone.now,

app/listeners/reporting_event_listener.rb

@@ -16,7 +16,7 @@ class ReportingEventListener < BaseListener
       event_start_time: conversation.created_at,
       event_end_time: conversation.updated_at
     )
-    reporting_event.save
+    reporting_event.save!
   end
 
   def first_reply_created(event)
@@ -39,6 +39,6 @@ class ReportingEventListener < BaseListener
     # rubocop:disable Rails/SkipsModelValidations
     conversation.update_columns(first_reply_created_at: message.created_at)
     # rubocop:enable Rails/SkipsModelValidations
-    reporting_event.save
+    reporting_event.save!
   end
 end

app/mailboxes/mailbox_helper.rb

@@ -4,7 +4,7 @@ module MailboxHelper
   def create_message
     return if @conversation.messages.find_by(source_id: processed_mail.message_id).present?
 
-    @message = @conversation.messages.create(
+    @message = @conversation.messages.create!(
       account_id: @conversation.account_id,
       sender: @conversation.contact,
       content: mail_content&.truncate(150_000),

app/models/channel/facebook_page.rb

@@ -39,7 +39,7 @@ class Channel::FacebookPage < ApplicationRecord
   def create_contact_inbox(instagram_id, name)
     ActiveRecord::Base.transaction do
       contact = inbox.account.contacts.create!(name: name)
-      ::ContactInbox.create(
+      ::ContactInbox.create!(
         contact_id: contact.id,
         inbox_id: inbox.id,
         source_id: instagram_id

app/services/line/incoming_message_service.rb

@@ -30,7 +30,7 @@ class Line::IncomingMessageService
   def message_created?(event)
     return unless event_type_message?(event)
 
-    @message = @conversation.messages.create(
+    @message = @conversation.messages.create!(
       content: event['message']['text'],
       account_id: @inbox.account_id,
       inbox_id: @inbox.id,

app/services/sms/incoming_message_service.rb

@@ -6,7 +6,7 @@ class Sms::IncomingMessageService
   def perform
     set_contact
     set_conversation
-    @message = @conversation.messages.create(
+    @message = @conversation.messages.create!(
       content: params[:text],
       account_id: @inbox.account_id,
       inbox_id: @inbox.id,

app/services/telegram/incoming_message_service.rb

@@ -12,7 +12,7 @@ class Telegram::IncomingMessageService
     set_contact
     update_contact_avatar
     set_conversation
-    @message = @conversation.messages.create(
+    @message = @conversation.messages.create!(
       content: params[:message][:text].presence || params[:message][:caption],
       account_id: @inbox.account_id,
       inbox_id: @inbox.id,

app/services/twilio/incoming_message_service.rb

@@ -8,7 +8,7 @@ class Twilio::IncomingMessageService
 
     set_contact
     set_conversation
-    @message = @conversation.messages.create(
+    @message = @conversation.messages.create!(
       content: params[:Body],
       account_id: @inbox.account_id,
       inbox_id: @inbox.id,

app/services/twitter/direct_message_parser_service.rb

@@ -7,7 +7,7 @@ class Twitter::DirectMessageParserService < Twitter::WebhooksBaseService
     set_inbox
     ensure_contacts
     set_conversation
-    @message = @conversation.messages.create(
+    @message = @conversation.messages.create!(
       content: message_create_data['message_data']['text'],
       account_id: @inbox.account_id,
       inbox_id: @inbox.id,
@@ -30,7 +30,7 @@ class Twitter::DirectMessageParserService < Twitter::WebhooksBaseService
   def save_media_urls(file)
     @message.content_attributes[:media_url] = file['media_url']
     @message.content_attributes[:display_url] = file['display_url']
-    @message.save
+    @message.save!
   end
 
   def direct_message_events_params
@@ -121,6 +121,6 @@ class Twitter::DirectMessageParserService < Twitter::WebhooksBaseService
         content_type: media['type']
       }
     )
-    @message.save
+    @message.save!
   end
 end

app/services/twitter/tweet_parser_service.rb

@@ -80,7 +80,7 @@ class Twitter::TweetParserService < Twitter::WebhooksBaseService
   def create_message
     find_or_create_contact(user)
     set_conversation
-    @conversation.messages.create(
+    @conversation.messages.create!(
       account_id: @inbox.account_id,
       sender: @contact,
       content: tweet_text,