fix: throttle stalecontacts job (#11430)
- throttle stale contacts job - process 20% accounts every day - reduce batch size from 100 to 20 - add delay between jobs
This commit is contained in:
@@ -3,44 +3,62 @@ require 'rails_helper'
|
||||
RSpec.describe Internal::ProcessStaleContactsJob do
|
||||
subject(:job) { described_class.perform_later }
|
||||
|
||||
it 'enqueues the job' do
|
||||
allow(ChatwootApp).to receive(:chatwoot_cloud?).and_return(true)
|
||||
expect { job }.to have_enqueued_job(described_class)
|
||||
.on_queue('housekeeping')
|
||||
context 'when in cloud environment' do
|
||||
before do
|
||||
allow(ChatwootApp).to receive(:chatwoot_cloud?).and_return(true)
|
||||
end
|
||||
|
||||
it 'processes accounts based on the day of month' do
|
||||
# Set a fixed day for testing
|
||||
day_of_month = 16
|
||||
remainder = day_of_month % described_class::DISTRIBUTION_GROUPS
|
||||
allow(Date).to receive(:current).and_return(Date.new(2025, 5, day_of_month))
|
||||
|
||||
# Create an account and set its ID to match today's pattern
|
||||
account = create(:account)
|
||||
allow(account).to receive(:id).and_return(remainder)
|
||||
|
||||
# Mock the Account.where to return our filtered accounts
|
||||
account_relation = double
|
||||
allow(Account).to receive(:where).with("id % #{described_class::DISTRIBUTION_GROUPS} = ?", remainder).and_return(account_relation)
|
||||
allow(account_relation).to receive(:find_each).and_yield(account)
|
||||
|
||||
# Mock the delay setting
|
||||
allow(Internal::RemoveStaleContactsJob).to receive(:set).and_return(Internal::RemoveStaleContactsJob)
|
||||
expect(Internal::RemoveStaleContactsJob).to receive(:perform_later).with(account)
|
||||
|
||||
described_class.perform_now
|
||||
end
|
||||
|
||||
it 'adds a delay between jobs' do
|
||||
day_of_month = 15
|
||||
remainder = day_of_month % described_class::DISTRIBUTION_GROUPS
|
||||
allow(Date).to receive(:current).and_return(Date.new(2025, 5, day_of_month))
|
||||
|
||||
account = create(:account)
|
||||
|
||||
account_relation = double
|
||||
allow(Account).to receive(:where).with("id % #{described_class::DISTRIBUTION_GROUPS} = ?", remainder).and_return(account_relation)
|
||||
allow(account_relation).to receive(:find_each).and_yield(account)
|
||||
|
||||
expect(Internal::RemoveStaleContactsJob).to receive(:set) do |args|
|
||||
expect(args[:wait]).to be_between(1.minute, 10.minutes)
|
||||
Internal::RemoveStaleContactsJob
|
||||
end
|
||||
expect(Internal::RemoveStaleContactsJob).to receive(:perform_later).with(account)
|
||||
|
||||
described_class.perform_now
|
||||
end
|
||||
end
|
||||
|
||||
it 'enqueues RemoveStaleContactsJob for each account' do
|
||||
allow(ChatwootApp).to receive(:chatwoot_cloud?).and_return(true)
|
||||
account1 = create(:account)
|
||||
account2 = create(:account)
|
||||
account3 = create(:account)
|
||||
context 'when not in cloud environment' do
|
||||
it 'does not process any accounts' do
|
||||
allow(ChatwootApp).to receive(:chatwoot_cloud?).and_return(false)
|
||||
|
||||
expect { described_class.perform_now }.to have_enqueued_job(Internal::RemoveStaleContactsJob)
|
||||
.with(account1)
|
||||
.on_queue('housekeeping')
|
||||
expect { described_class.perform_now }.to have_enqueued_job(Internal::RemoveStaleContactsJob)
|
||||
.with(account2)
|
||||
.on_queue('housekeeping')
|
||||
expect { described_class.perform_now }.to have_enqueued_job(Internal::RemoveStaleContactsJob)
|
||||
.with(account3)
|
||||
.on_queue('housekeeping')
|
||||
end
|
||||
expect(Account).not_to receive(:where)
|
||||
expect(Internal::RemoveStaleContactsJob).not_to receive(:perform_later)
|
||||
|
||||
it 'processes accounts in batches' do
|
||||
allow(ChatwootApp).to receive(:chatwoot_cloud?).and_return(true)
|
||||
account = create(:account)
|
||||
allow(Account).to receive(:find_in_batches).with(batch_size: 100).and_yield([account])
|
||||
|
||||
expect(Internal::RemoveStaleContactsJob).to receive(:perform_later).with(account)
|
||||
described_class.perform_now
|
||||
end
|
||||
|
||||
it 'does not process accounts when not in cloud environment' do
|
||||
allow(ChatwootApp).to receive(:chatwoot_cloud?).and_return(false)
|
||||
create(:account)
|
||||
|
||||
expect(Account).not_to receive(:find_in_batches)
|
||||
expect(Internal::RemoveStaleContactsJob).not_to receive(:perform_later)
|
||||
described_class.perform_now
|
||||
described_class.perform_now
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user