chore: Fix issue with conversation assignment notifications (#3661)

- fixes issues with conversation assignment notifications not working in certain cases
This commit is contained in:
Sojan Jose
2021-12-28 21:53:13 +05:30
committed by GitHub
parent 9606abe251
commit 577e9905c6
4 changed files with 10 additions and 8 deletions

View File

@@ -16,7 +16,7 @@ class NotificationListener < BaseListener
def assignee_changed(event)
conversation, account = extract_conversation_and_account(event)
assignee = conversation.assignee
return unless conversation.notifiable_assignee_change?
return if event.data[:notifiable_assignee_change].blank?
return if conversation.pending?
NotificationBuilder.new(

View File

@@ -142,9 +142,9 @@ class Conversation < ApplicationRecord
end
def notifiable_assignee_change?
return false if self_assign?(assignee_id)
return false unless saved_change_to_assignee_id?
return false if assignee_id.blank?
return false if self_assign?(assignee_id)
true
end
@@ -202,7 +202,7 @@ class Conversation < ApplicationRecord
end
def dispatcher_dispatch(event_name)
Rails.configuration.dispatcher.dispatch(event_name, Time.zone.now, conversation: self)
Rails.configuration.dispatcher.dispatch(event_name, Time.zone.now, conversation: self, notifiable_assignee_change: notifiable_assignee_change?)
end
def conversation_status_changed_to_open?