From 56e93d152dea481a40de5db028338837f46b6705 Mon Sep 17 00:00:00 2001 From: Sivin Varghese <64252451+iamsivin@users.noreply.github.com> Date: Wed, 7 Aug 2024 14:14:41 +0530 Subject: [PATCH] feat: Replace the use of `mentionSelectionKeyboard` mixin to a composable (#9904) --- .../widgets/conversation/TagAgents.vue | 221 +++++++------- .../widgets/mentions/MentionBox.vue | 129 ++++---- .../mentions/mentionSelectionKeyboardMixin.js | 62 ---- .../mentionSelectionKeyboardMixin.spec.js | 69 ----- .../spec/useKeyboardNavigableList.spec.js | 280 ++++++++++++++++++ .../composables/useKeyboardNavigableList.js | 118 ++++++++ .../portal/components/SearchSuggestions.vue | 44 ++- 7 files changed, 606 insertions(+), 317 deletions(-) delete mode 100644 app/javascript/dashboard/components/widgets/mentions/mentionSelectionKeyboardMixin.js delete mode 100644 app/javascript/dashboard/components/widgets/mentions/specs/mentionSelectionKeyboardMixin.spec.js create mode 100644 app/javascript/dashboard/composables/spec/useKeyboardNavigableList.spec.js create mode 100644 app/javascript/dashboard/composables/useKeyboardNavigableList.js diff --git a/app/javascript/dashboard/components/widgets/conversation/TagAgents.vue b/app/javascript/dashboard/components/widgets/conversation/TagAgents.vue index a6fdb6b8a..d4c5a0930 100644 --- a/app/javascript/dashboard/components/widgets/conversation/TagAgents.vue +++ b/app/javascript/dashboard/components/widgets/conversation/TagAgents.vue @@ -1,124 +1,119 @@ - - - diff --git a/app/javascript/dashboard/components/widgets/mentions/MentionBox.vue b/app/javascript/dashboard/components/widgets/mentions/MentionBox.vue index bd1bddbd0..1d1a51ff5 100644 --- a/app/javascript/dashboard/components/widgets/mentions/MentionBox.vue +++ b/app/javascript/dashboard/components/widgets/mentions/MentionBox.vue @@ -1,71 +1,82 @@ -