LeadMagnet/leadchat
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

feat: Update custom filter for present/not_present operator (#3361)

Browse Source
This commit is contained in:
Tejaswini Chile
2021-11-12 11:30:39 +05:30
committed by GitHub
parent 58aae7a4a9
commit 564fa5f392
3 changed files with 55 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
spec/services/conversations/filter_service_spec.rb
View File

@@ -6,15 +6,17 @@ describe ::Conversations::FilterService do
let!(:account) { create(:account) }
let!(:user_1) { create(:user, account: account) }
let!(:user_2) { create(:user, account: account) }
let!(:campaign_1) { create(:campaign, title: 'Test Campaign', account: account) }
let!(:campaign_2) { create(:campaign, title: 'Campaign', account: account) }
let!(:inbox) { create(:inbox, account: account, enable_auto_assignment: false) }
before do
create(:inbox_member, user: user_1, inbox: inbox)
create(:inbox_member, user: user_2, inbox: inbox)
create(:conversation, account: account, inbox: inbox, assignee: user_1)
create(:conversation, account: account, inbox: inbox, assignee: user_1,
create(:conversation, account: account, inbox: inbox, assignee: user_1, campaign_id: campaign_1.id,
status: 'pending', additional_attributes: { 'browser_language': 'en' })
create(:conversation, account: account, inbox: inbox, assignee: user_1,
create(:conversation, account: account, inbox: inbox, assignee: user_1, campaign_id: campaign_2.id,
status: 'pending', additional_attributes: { 'browser_language': 'en' })
create(:conversation, account: account, inbox: inbox, assignee: user_2)
# unassigned conversation
@@ -29,14 +31,14 @@ describe ::Conversations::FilterService do
[
{
attribute_key: 'browser_language',
filter_operator: 'equal_to',
values: ['en'],
filter_operator: 'contains',
values: 'en',
query_operator: 'AND'
}.with_indifferent_access,
{
attribute_key: 'status',
filter_operator: 'equal_to',
values: %w[open pending],
filter_operator: 'not_equal_to',
values: %w[resolved],
query_operator: nil
}.with_indifferent_access
]
@@ -71,6 +73,30 @@ describe ::Conversations::FilterService do
result = filter_service.new(params, user_1).perform
expect(result.length).to be 2
end
it 'filter conversations by is_present filter_operator' do
params[:payload] = [
{
attribute_key: 'assignee_id',
filter_operator: 'equal_to',
values: [
user_1.id,
user_2.id
],
query_operator: 'AND'
}.with_indifferent_access,
{
attribute_key: 'campaign_id',
filter_operator: 'is_present',
values: [],
query_operator: nil
}.with_indifferent_access
]
result = filter_service.new(params, user_1).perform
expect(result[:count][:all_count]).to be 2
expect(result[:conversations].pluck(:campaign_id).sort).to eq [campaign_2.id, campaign_1.id].sort
end
end
end
end