From 4d49b81f1c95afa9558e5413757871d3513cdcdb Mon Sep 17 00:00:00 2001 From: Shivam Mishra Date: Fri, 14 Apr 2023 15:22:08 +0530 Subject: [PATCH] fix: use response.status instead of success (#6906) * fix: use response.status instead of success * refactor: use sentry to capture exception * refactor: explicitly convert to i --- app/controllers/twitter/callbacks_controller.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/controllers/twitter/callbacks_controller.rb b/app/controllers/twitter/callbacks_controller.rb index e92b89d1b..19a61f819 100644 --- a/app/controllers/twitter/callbacks_controller.rb +++ b/app/controllers/twitter/callbacks_controller.rb @@ -14,7 +14,7 @@ class Twitter::CallbacksController < Twitter::BaseController redirect_to app_twitter_inbox_agents_url(account_id: account.id, inbox_id: inbox.id) end rescue StandardError => e - Rails.logger.error e + ChatwootExceptionTracker.new(e).capture_exception redirect_to twitter_app_redirect_url end @@ -60,7 +60,7 @@ class Twitter::CallbacksController < Twitter::BaseController def save_profile_image(inbox) response = twitter_client.user_show(screen_name: inbox.name) - return unless response.success? + return unless response.status.to_i == 200 parsed_user_profile = JSON.parse(response.read_body)