feat: Throttle meta request for large chat size (#10518)

For large accounts with huge volumes of messages, it can be very
wasteful to make the meta request so often. It also puts un-necessary
load on the DB bombarding it with so many requests. This PR fixes it by
throttling the requests to 5 seconds for all users with more than 1000
accessible chats.

### Why not cache this value in the backend?

Well, it's a bit tricky, since a user can have different permissions
over inboxes and can see different chats, maintaining a cache for each
of them is not effective, besides the requests will reach the server
anyway.
This commit is contained in:
Shivam Mishra
2024-12-06 12:05:30 +05:30
committed by GitHub
parent b116ab5ad3
commit 3fd585f40b
3 changed files with 16 additions and 3 deletions

View File

@@ -5,6 +5,7 @@ const state = {
mineCount: 0,
unAssignedCount: 0,
allCount: 0,
updatedOn: null,
};
export const getters = {
@@ -12,7 +13,17 @@ export const getters = {
};
export const actions = {
get: async ({ commit }, params) => {
get: async ({ commit, state: $state }, params) => {
const currentTime = new Date();
const lastUpdatedTime = new Date($state.updatedOn);
// Skip large accounts from making too many requests
if (currentTime - lastUpdatedTime < 10000 && $state.allCount > 1000) {
// eslint-disable-next-line no-console
console.warn('Skipping conversation meta fetch');
return;
}
try {
const response = await ConversationApi.meta(params);
const {
@@ -40,6 +51,7 @@ export const mutations = {
$state.mineCount = mineCount;
$state.allCount = allCount;
$state.unAssignedCount = unAssignedCount;
$state.updatedOn = new Date();
},
};