LeadMagnet/leadchat
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

feat: expiry for cache keys [CW-3038] (#8793)

Browse Source 
* feat: set cache keys for 3 days only

* feat: invalidate should set the latest timestamp

* refactor: cache_keys concern

* remove invalidate_cache method
* refactor reset to set to new value instead of delete
* ensure only one event is dispatched

* feat: set expiry to 24 hours

* chore: make expiry 48 hours

* feat: include destroy event

* feat: set expiry to 72 days

* fix: typo

* test: cache update after `touch`

* test: update cache keys

* refactor: remove after_touch, it's already handled in commit
This commit is contained in:
Shivam Mishra
2024-01-29 15:27:26 +05:30
committed by GitHub
parent cf664ca2a0
commit 3ed80fa867
5 changed files with 41 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/concerns/account_cache_revalidator.rb
View File

@@ -2,7 +2,7 @@ module AccountCacheRevalidator
extend ActiveSupport::Concern
included do
after_commit :update_account_cache, on: [:create, :update]
after_commit :update_account_cache, on: [:create, :update, :destroy]
end
def update_account_cache

20
app/models/concerns/cache_keys.rb
View File

@@ -4,6 +4,8 @@ module CacheKeys
include CacheKeysHelper
include Events::Types
CACHE_KEYS_EXPIRY = 72.hours
included do
class_attribute :cacheable_models
self.cacheable_models = [Label, Inbox, Team]
@@ -18,26 +20,26 @@ module CacheKeys
keys
end
def invalidate_cache_key_for(key)
prefixed_cache_key = get_prefixed_cache_key(id, key)
Redis::Alfred.delete(prefixed_cache_key)
dispatch_cache_update_event
end
def update_cache_key(key)
prefixed_cache_key = get_prefixed_cache_key(id, key)
Redis::Alfred.set(prefixed_cache_key, Time.now.utc.to_i)
update_cache_key_for_account(id, key)
dispatch_cache_update_event
end
def reset_cache_keys
self.class.cacheable_models.each do |model|
invalidate_cache_key_for(model.name.underscore)
update_cache_key_for_account(id, model.name.underscore)
end
dispatch_cache_update_event
end
private
def update_cache_key_for_account(account_id, key)
prefixed_cache_key = get_prefixed_cache_key(account_id, key)
Redis::Alfred.setex(prefixed_cache_key, Time.now.utc.to_i, CACHE_KEYS_EXPIRY)
end
def dispatch_cache_update_event
Rails.configuration.dispatcher.dispatch(ACCOUNT_CACHE_INVALIDATED, Time.zone.now, cache_keys: cache_keys, account: self)
end