From 3a71fe32605a74d611820d4f494ff531ae6817d0 Mon Sep 17 00:00:00 2001 From: Sojan Jose Date: Fri, 21 Oct 2022 18:06:02 -0700 Subject: [PATCH] chore: Stop duplicate websocket updates for conversation updates (#5711) - remove extra dispatch for label updates --- app/models/conversation.rb | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/app/models/conversation.rb b/app/models/conversation.rb index 3a1abf335..03fedb6e4 100644 --- a/app/models/conversation.rb +++ b/app/models/conversation.rb @@ -219,7 +219,7 @@ class Conversation < ApplicationRecord def notify_conversation_updation return unless previous_changes.keys.present? && (previous_changes.keys & %w[team_id assignee_id status snoozed_until - custom_attributes]).present? + custom_attributes label_list]).present? dispatcher_dispatch(CONVERSATION_UPDATED, previous_changes) end @@ -262,8 +262,6 @@ class Conversation < ApplicationRecord previous_labels, current_labels = previous_changes[:label_list] return unless (previous_labels.is_a? Array) && (current_labels.is_a? Array) - dispatcher_dispatch(CONVERSATION_UPDATED, previous_changes) - create_label_added(user_name, current_labels - previous_labels) create_label_removed(user_name, previous_labels - current_labels) end