Refactoring the code for pub sub (#155)
- We were using the attribute name 'channel' to store pubsub tokens, which was confusing. - switched to faker from ffaker - spec for contact.rb
This commit is contained in:
@@ -6,7 +6,6 @@ FactoryBot.define do
|
||||
sequence(:email) { |n| "widget-#{n}@example.com" }
|
||||
phone_number { "+123456789011" }
|
||||
source_id { rand(100) }
|
||||
chat_channel { "chat_channel" }
|
||||
account
|
||||
inbox
|
||||
end
|
||||
|
||||
@@ -8,8 +8,8 @@ FactoryBot.define do
|
||||
|
||||
provider { 'email' }
|
||||
uid { SecureRandom.uuid }
|
||||
name { FFaker::Name.name }
|
||||
nickname { FFaker::InternetSE.user_name_from_name(name) }
|
||||
name { Faker::Name.name }
|
||||
nickname { Faker::Name.first_name }
|
||||
email { nickname + '@example.com' }
|
||||
role { 'agent' }
|
||||
password { "password" }
|
||||
|
||||
32
spec/models/contact_spec.rb
Normal file
32
spec/models/contact_spec.rb
Normal file
@@ -0,0 +1,32 @@
|
||||
# frozen_string_literal: true
|
||||
|
||||
require 'rails_helper'
|
||||
|
||||
RSpec.describe Contact do
|
||||
context 'validations' do
|
||||
it { is_expected.to validate_presence_of(:account_id) }
|
||||
it { is_expected.to validate_presence_of(:inbox_id) }
|
||||
end
|
||||
|
||||
context 'associations' do
|
||||
it { is_expected.to belong_to(:account) }
|
||||
it { is_expected.to belong_to(:inbox) }
|
||||
it { is_expected.to have_many(:conversations).dependent(:destroy) }
|
||||
end
|
||||
|
||||
describe 'pubsub_token' do
|
||||
let(:user) { create(:user) }
|
||||
|
||||
it 'gets created on object create' do
|
||||
obj = user
|
||||
expect(obj.pubsub_token).not_to eq(nil)
|
||||
end
|
||||
|
||||
it 'does not get updated on object update' do
|
||||
obj = user
|
||||
old_token = obj.pubsub_token
|
||||
obj.update(name: 'test')
|
||||
expect(obj.pubsub_token).to eq(old_token)
|
||||
end
|
||||
end
|
||||
end
|
||||
@@ -21,4 +21,20 @@ RSpec.describe User do
|
||||
it { is_expected.to have_many(:assigned_inboxes).through(:inbox_members) }
|
||||
it { is_expected.to have_many(:messages) }
|
||||
end
|
||||
|
||||
describe 'pubsub_token' do
|
||||
let(:user) { create(:user) }
|
||||
|
||||
it 'gets created on object create' do
|
||||
obj = user
|
||||
expect(obj.pubsub_token).not_to eq(nil)
|
||||
end
|
||||
|
||||
it 'does not get updated on object update' do
|
||||
obj = user
|
||||
old_token = obj.pubsub_token
|
||||
obj.update(name: 'test')
|
||||
expect(obj.pubsub_token).to eq(old_token)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user