Bug : Inbox Filter indicator is removed when a conversation is selected (#535)
This commit is contained in:
committed by
GitHub
parent
bc884ae184
commit
330bf87f08
@@ -4,3 +4,10 @@ export const frontendURL = (path, params) => {
|
||||
const stringifiedParams = params ? `?${queryString.stringify(params)}` : '';
|
||||
return `/app/${path}${stringifiedParams}`;
|
||||
};
|
||||
|
||||
export const conversationUrl = (activeInbox, id) => {
|
||||
const path = activeInbox
|
||||
? `inbox/${activeInbox}/conversations/${id}`
|
||||
: `conversations/${id}`;
|
||||
return path;
|
||||
};
|
||||
|
||||
21
app/javascript/dashboard/helper/spec/URLHelper.spec.js
Normal file
21
app/javascript/dashboard/helper/spec/URLHelper.spec.js
Normal file
@@ -0,0 +1,21 @@
|
||||
import { frontendURL, conversationUrl } from '../URLHelper';
|
||||
|
||||
describe('#URL Helpers', () => {
|
||||
describe('conversationUrl', () => {
|
||||
it('should return direct conversation URL if activeInbox is nil', () => {
|
||||
expect(conversationUrl(undefined, 1)).toBe('conversations/1');
|
||||
});
|
||||
it('should return ibox conversation URL if activeInbox is not nil', () => {
|
||||
expect(conversationUrl(2, 1)).toBe('inbox/2/conversations/1');
|
||||
});
|
||||
});
|
||||
|
||||
describe('frontendURL', () => {
|
||||
it('should return url without params if params passed is nil', () => {
|
||||
expect(frontendURL('main', null)).toBe('/app/main');
|
||||
});
|
||||
it('should return url without params if params passed is not nil', () => {
|
||||
expect(frontendURL('main', { ping: 'pong' })).toBe('/app/main?ping=pong');
|
||||
});
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user