From 2d70131097e80374c48b82dc438ac4437184e2e4 Mon Sep 17 00:00:00 2001
From: Pranav Raj S <pranav@thoughtwoot.com>
Date: Tue, 17 Nov 2020 09:15:57 +0530
Subject: [PATCH] fix: Remove duplicate API calls for conversation (#1419)

---
 app/javascript/dashboard/components/ChatList.vue  |  4 +++-
 .../dashboard/conversation/ConversationView.vue   | 15 +++++++++------
 2 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/app/javascript/dashboard/components/ChatList.vue b/app/javascript/dashboard/components/ChatList.vue
index 8a8c59551..27f89b550 100644
--- a/app/javascript/dashboard/components/ChatList.vue
+++ b/app/javascript/dashboard/components/ChatList.vue
@@ -184,7 +184,9 @@ export default {
       this.fetchConversations();
     },
     fetchConversations() {
-      this.$store.dispatch('fetchAllConversations', this.conversationFilters);
+      this.$store
+        .dispatch('fetchAllConversations', this.conversationFilters)
+        .then(() => this.$emit('conversation-load'));
     },
     updateAssigneeTab(selectedTab) {
       if (this.activeAssigneeTab !== selectedTab) {
diff --git a/app/javascript/dashboard/routes/dashboard/conversation/ConversationView.vue b/app/javascript/dashboard/routes/dashboard/conversation/ConversationView.vue
index 14978599b..8f7709569 100644
--- a/app/javascript/dashboard/routes/dashboard/conversation/ConversationView.vue
+++ b/app/javascript/dashboard/routes/dashboard/conversation/ConversationView.vue
@@ -1,6 +1,10 @@
 <template>
   <section class="app-content columns">
-    <chat-list :conversation-inbox="inboxId" :label="label">
+    <chat-list
+      :conversation-inbox="inboxId"
+      :label="label"
+      @conversation-load="onConversationLoad"
+    >
       <button class="search--button" @click="onSearch">
         <i class="ion-ios-search-strong search--icon" />
         <div class="text-truncate">
@@ -83,24 +87,23 @@ export default {
 
   mounted() {
     this.$store.dispatch('agents/get');
-
     this.initialize();
-    this.fetchConversation();
-
     this.$watch('$store.state.route', () => this.initialize());
     this.$watch('chatList.length', () => {
-      this.fetchConversation();
       this.setActiveChat();
     });
   },
 
   methods: {
+    onConversationLoad() {
+      this.fetchConversationIfUnavailable();
+    },
     initialize() {
       this.$store.dispatch('setActiveInbox', this.inboxId);
       this.setActiveChat();
     },
 
-    fetchConversation() {
+    fetchConversationIfUnavailable() {
       if (!this.conversationId) {
         return;
       }