LeadMagnet/leadchat
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[Refactor] Cleanup agent store and actions (#373)

Browse Source 
* Cleanup agent store and actions

* Move set/create/update/destroy to helpers

* Update mutation specs

* Add specs for API helper

* Fix edit/delete action visibility

* Add actions specs

* Remove unused API helpers

* Remove duplicates

* Remove duplicates

* Fix duplicate
This commit is contained in:
Pranav Raj S
2019-12-21 22:54:35 +05:30
committed by Sojan Jose
parent a92e3817f8
commit 2ce7438c79
26 changed files with 613 additions and 576 deletions
Download Patch File Download Diff File Expand all files Collapse all files

94
app/javascript/dashboard/store/modules/specs/agents/actions.spec.js Normal file
View File

@@ -0,0 +1,94 @@
import axios from 'axios';
import { actions } from '../../agents';
import * as types from '../../../mutation-types';
import agentList from './fixtures';
const commit = jest.fn();
global.axios = axios;
jest.mock('axios');
describe('#actions', () => {
describe('#get', () => {
it('sends correct actions if API is success', async () => {
axios.get.mockResolvedValue({ data: agentList });
await actions.get({ commit });
expect(commit.mock.calls).toEqual([
[types.default.SET_AGENT_FETCHING_STATUS, true],
[types.default.SET_AGENT_FETCHING_STATUS, false],
[types.default.SET_AGENTS, agentList],
]);
});
it('sends correct actions if API is error', async () => {
axios.get.mockRejectedValue({ message: 'Incorrect header' });
await actions.get({ commit });
expect(commit.mock.calls).toEqual([
[types.default.SET_AGENT_FETCHING_STATUS, true],
[types.default.SET_AGENT_FETCHING_STATUS, false],
]);
});
});
describe('#create', () => {
it('sends correct actions if API is success', async () => {
axios.post.mockResolvedValue({ data: agentList[0] });
await actions.create({ commit }, agentList[0]);
expect(commit.mock.calls).toEqual([
[types.default.SET_AGENT_CREATING_STATUS, true],
[types.default.ADD_AGENT, agentList[0]],
[types.default.SET_AGENT_CREATING_STATUS, false],
]);
});
it('sends correct actions if API is error', async () => {
axios.post.mockRejectedValue({ message: 'Incorrect header' });
await expect(actions.create({ commit })).rejects.toThrow(Error);
expect(commit.mock.calls).toEqual([
[types.default.SET_AGENT_CREATING_STATUS, true],
[types.default.SET_AGENT_CREATING_STATUS, false],
]);
});
});
describe('#update', () => {
it('sends correct actions if API is success', async () => {
axios.patch.mockResolvedValue({ data: agentList[0] });
await actions.update({ commit }, agentList[0]);
expect(commit.mock.calls).toEqual([
[types.default.SET_AGENT_UPDATING_STATUS, true],
[types.default.EDIT_AGENT, agentList[0]],
[types.default.SET_AGENT_UPDATING_STATUS, false],
]);
});
it('sends correct actions if API is error', async () => {
axios.patch.mockRejectedValue({ message: 'Incorrect header' });
await expect(actions.update({ commit }, agentList[0])).rejects.toThrow(
Error
);
expect(commit.mock.calls).toEqual([
[types.default.SET_AGENT_UPDATING_STATUS, true],
[types.default.SET_AGENT_UPDATING_STATUS, false],
]);
});
});
describe('#delete', () => {
it('sends correct actions if API is success', async () => {
axios.delete.mockResolvedValue({ data: agentList[0] });
await actions.delete({ commit }, agentList[0].id);
expect(commit.mock.calls).toEqual([
[types.default.SET_AGENT_DELETING_STATUS, true],
[types.default.DELETE_AGENT, agentList[0].id],
[types.default.SET_AGENT_DELETING_STATUS, false],
]);
});
it('sends correct actions if API is error', async () => {
axios.delete.mockRejectedValue({ message: 'Incorrect header' });
await expect(actions.delete({ commit }, agentList[0].id)).rejects.toThrow(
Error
);
expect(commit.mock.calls).toEqual([
[types.default.SET_AGENT_DELETING_STATUS, true],
[types.default.SET_AGENT_DELETING_STATUS, false],
]);
});
});
});

28
app/javascript/dashboard/store/modules/specs/agents/fixtures.js Normal file
View File

@@ -0,0 +1,28 @@
export default [
{
id: 1,
provider: 'email',
uid: 'agent1@chatwoot.com',
name: 'Agent1',
email: 'agent1@chatwoot.com',
account_id: 1,
created_at: '2019-11-18T02:21:06.225Z',
updated_at: '2019-12-20T07:43:35.794Z',
pubsub_token: 'random-1',
role: 'agent',
confirmed: true,
},
{
id: 2,
provider: 'email',
uid: 'agent2@chatwoot.com',
name: 'Agent2',
email: 'agent2@chatwoot.com',
account_id: 1,
created_at: '2019-11-18T02:21:06.225Z',
updated_at: '2019-12-20T07:43:35.794Z',
pubsub_token: 'random-2',
role: 'agent',
confirmed: true,
},
];

80
app/javascript/dashboard/store/modules/specs/agents/getters.spec.js Normal file
View File

@@ -0,0 +1,80 @@
import { getters } from '../../agents';
describe('#getters', () => {
it('getAgents', () => {
const state = {
records: [
{
id: 1,
name: 'Agent 1',
email: 'agent1@chatwoot.com',
confirmed: true,
},
{
id: 2,
name: 'Agent 2',
email: 'agent2@chatwoot.com',
confirmed: false,
},
],
};
expect(getters.getAgents(state)).toEqual([
{
id: 1,
name: 'Agent 1',
email: 'agent1@chatwoot.com',
confirmed: true,
},
{
id: 2,
name: 'Agent 2',
email: 'agent2@chatwoot.com',
confirmed: false,
},
]);
});
it('getVerifiedAgents', () => {
const state = {
records: [
{
id: 1,
name: 'Agent 1',
email: 'agent1@chatwoot.com',
confirmed: true,
},
{
id: 2,
name: 'Agent 2',
email: 'agent2@chatwoot.com',
confirmed: false,
},
],
};
expect(getters.getVerifiedAgents(state)).toEqual([
{
id: 1,
name: 'Agent 1',
email: 'agent1@chatwoot.com',
confirmed: true,
},
]);
});
it('getUIFlags', () => {
const state = {
uiFlags: {
isFetching: true,
isCreating: false,
isUpdating: false,
isDeleting: false,
},
};
expect(getters.getUIFlags(state)).toEqual({
isFetching: true,
isCreating: false,
isUpdating: false,
isDeleting: false,
});
});
});

63
app/javascript/dashboard/store/modules/specs/agents/mutations.spec.js Normal file
View File

@@ -0,0 +1,63 @@
import * as types from '../../../mutation-types';
import { mutations } from '../../agents';
describe('#mutations', () => {
describe('#SET_AGENTS', () => {
it('set agent records', () => {
const state = { records: [] };
mutations[types.default.SET_AGENTS](state, [
{ id: 1, name: 'Agent1', email: 'agent1@chatwoot.com' },
]);
expect(state.records).toEqual([
{
id: 1,
name: 'Agent1',
email: 'agent1@chatwoot.com',
},
]);
});
});
describe('#ADD_AGENT', () => {
it('push newly created agent data to the store', () => {
const state = {
records: [{ id: 1, name: 'Agent1', email: 'agent1@chatwoot.com' }],
};
mutations[types.default.ADD_AGENT](state, {
id: 2,
name: 'Agent2',
email: 'agent2@chatwoot.com',
});
expect(state.records).toEqual([
{ id: 1, name: 'Agent1', email: 'agent1@chatwoot.com' },
{ id: 2, name: 'Agent2', email: 'agent2@chatwoot.com' },
]);
});
});
describe('#EDIT_AGENT', () => {
it('sets allMessagesLoaded flag if payload is empty', () => {
const state = {
records: [{ id: 1, name: 'Agent1', email: 'agent1@chatwoot.com' }],
};
mutations[types.default.EDIT_AGENT](state, {
id: 1,
name: 'Agent2',
email: 'agent2@chatwoot.com',
});
expect(state.records).toEqual([
{ id: 1, name: 'Agent2', email: 'agent2@chatwoot.com' },
]);
});
});
describe('#DELETE_AGENT', () => {
it('sets allMessagesLoaded flag if payload is empty', () => {
const state = {
records: [{ id: 1, name: 'Agent1', email: 'agent1@chatwoot.com' }],
};
mutations[types.default.DELETE_AGENT](state, 1);
expect(state.records).toEqual([]);
});
});
});