LeadMagnet/leadchat
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

fix: Handle Twilio::REST::RestError (#8257)

Browse Source
This commit is contained in:
Muhsin Keloth
2023-10-31 16:23:34 +05:30
committed by GitHub
parent 11b27f9805
commit 29f18c7f18
2 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/services/twilio/send_on_twilio_service.rb
View File

@@ -8,8 +8,9 @@ class Twilio::SendOnTwilioService < Base::SendOnChannelService
def perform_reply def perform_reply
begin begin
twilio_message = channel.send_message(**message_params) twilio_message = channel.send_message(**message_params)
rescue Twilio::REST::TwilioError => e rescue Twilio::REST::TwilioError, Twilio::REST::RestError => e
ChatwootExceptionTracker.new(e, user: message.sender, account: message.account).capture_exception ChatwootExceptionTracker.new(e, user: message.sender, account: message.account).capture_exception
message.update!(status: :failed, external_error: e.message)
end end
message.update!(source_id: twilio_message.sid) if twilio_message message.update!(source_id: twilio_message.sid) if twilio_message
end end

10
spec/services/twilio/send_on_twilio_service_spec.rb
View File

@@ -96,5 +96,15 @@ describe Twilio::SendOnTwilioService do
described_class.new(message: message).perform described_class.new(message: message).perform
expect(messages_double).to have_received(:create).with(hash_including(media_url: [anything])) expect(messages_double).to have_received(:create).with(hash_including(media_url: [anything]))
end end
it 'if message is sent from chatwoot fails' do
allow(messages_double).to receive(:create).and_raise(Twilio::REST::TwilioError)
outgoing_message = create(
:message, message_type: 'outgoing', inbox: twilio_inbox, account: account, conversation: conversation
)
described_class.new(message: outgoing_message).perform
expect(outgoing_message.reload.status).to eq('failed')
end
end end
end end