LeadMagnet/leadchat
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

fix: Conversation assignment notification title (#9071)

Browse Source
This commit is contained in:
Muhsin Keloth
2024-03-06 23:05:13 +05:30
committed by GitHub
parent ef90b7a3d8
commit 216de4d123
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/models/notification.rb
View File

@@ -106,8 +106,10 @@ class Notification < ApplicationRecord
case notification_type case notification_type
when 'conversation_creation' when 'conversation_creation'
message_body(conversation.messages.first) message_body(conversation.messages.first)
when 'assigned_conversation_new_message', 'participating_conversation_new_message', 'conversation_assignment', 'conversation_mention' when 'assigned_conversation_new_message', 'participating_conversation_new_message', 'conversation_mention'
message_body(secondary_actor) message_body(secondary_actor)
when 'conversation_assignment'
message_body(conversation.messages.incoming.last)
else else
'' ''
end end

7
spec/models/notification_spec.rb
View File

@@ -76,6 +76,13 @@ has been assigned to you"
expect(notification.push_message_body).to eq "#{message.sender.name}: #{message.content.truncate_words(10)}" expect(notification.push_message_body).to eq "#{message.sender.name}: #{message.content.truncate_words(10)}"
end end
it 'returns appropriate body suited for the notification type conversation_assignment' do
conversation = create(:conversation)
message = create(:message, sender: create(:user), content: Faker::Lorem.paragraphs(number: 2), conversation: conversation)
notification = create(:notification, notification_type: 'conversation_assignment', primary_actor: conversation, secondary_actor: message)
expect(notification.push_message_body).to eq "#{message.sender.name}: #{message.content.truncate_words(10)}"
end
it 'returns appropriate body suited for the notification type assigned_conversation_new_message' do it 'returns appropriate body suited for the notification type assigned_conversation_new_message' do
conversation = create(:conversation) conversation = create(:conversation)
message = create(:message, sender: create(:user), content: Faker::Lorem.paragraphs(number: 2), conversation: conversation) message = create(:message, sender: create(:user), content: Faker::Lorem.paragraphs(number: 2), conversation: conversation)