LeadMagnet/leadchat
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

fix: Standardize name validation on agent / profile pages (#1720)

Browse Source
This commit is contained in:
Karthik Sivadas
2021-02-04 20:08:46 +05:30
committed by GitHub
parent 6a614a520b
commit 2012aab1d5
5 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/javascript/dashboard/routes/dashboard/settings/agents/AddAgent.vue
View File

@@ -102,7 +102,7 @@ export default {
validations: { validations: {
agentName: { agentName: {
required, required,
minLength: minLength(4), minLength: minLength(1),
}, },
agentEmail: { agentEmail: {
required, required,

2
app/javascript/dashboard/routes/dashboard/settings/agents/EditAgent.vue
View File

@@ -112,7 +112,7 @@ export default {
validations: { validations: {
agentName: { agentName: {
required, required,
minLength: minLength(4), minLength: minLength(1),
}, },
agentType: { agentType: {
required, required,

1
app/javascript/dashboard/routes/dashboard/settings/profile/Index.vue
View File

@@ -136,6 +136,7 @@ export default {
validations: { validations: {
name: { name: {
required, required,
minLength: minLength(1),
}, },
displayName: {}, displayName: {},
email: { email: {

1
app/models/user.rb
View File

@@ -62,6 +62,7 @@ class User < ApplicationRecord
# validates_uniqueness_of :email, scope: :account_id # validates_uniqueness_of :email, scope: :account_id
validates :email, :name, presence: true validates :email, :name, presence: true
validates_length_of :name, minimum: 1
has_many :account_users, dependent: :destroy has_many :account_users, dependent: :destroy
has_many :accounts, through: :account_users has_many :accounts, through: :account_users

1
spec/models/user_spec.rb
View File

@@ -9,6 +9,7 @@ RSpec.describe User do
context 'validations' do context 'validations' do
it { is_expected.to validate_presence_of(:email) } it { is_expected.to validate_presence_of(:email) }
it { is_expected.to validate_presence_of(:name) } it { is_expected.to validate_presence_of(:name) }
it { is_expected.to validate_length_of(:name).is_at_least(1) }
end end
context 'associations' do context 'associations' do