From 1bf3ad9a088995469edab4031700c3a2cab0aa3e Mon Sep 17 00:00:00 2001 From: Muhsin Keloth Date: Thu, 25 Apr 2024 11:25:19 +0530 Subject: [PATCH] fix: Remove unnecessary attributes from notification deleted action cable event payload (#9295) fix: simplify notification deleted payload event --- app/listeners/action_cable_listener.rb | 2 +- spec/listeners/action_cable_listener_spec.rb | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/app/listeners/action_cable_listener.rb b/app/listeners/action_cable_listener.rb index 5aac56db3..99a8fe2af 100644 --- a/app/listeners/action_cable_listener.rb +++ b/app/listeners/action_cable_listener.rb @@ -18,7 +18,7 @@ class ActionCableListener < BaseListener notification, account, unread_count, count = extract_notification_and_account(event) tokens = [event.data[:notification].user.pubsub_token] - broadcast(account, tokens, NOTIFICATION_DELETED, { notification: notification.push_event_data, unread_count: unread_count, count: count }) + broadcast(account, tokens, NOTIFICATION_DELETED, { notification: { id: notification.id }, unread_count: unread_count, count: count }) end def account_cache_invalidated(event) diff --git a/spec/listeners/action_cable_listener_spec.rb b/spec/listeners/action_cable_listener_spec.rb index 5802ce00a..b353f330d 100644 --- a/spec/listeners/action_cable_listener_spec.rb +++ b/spec/listeners/action_cable_listener_spec.rb @@ -142,7 +142,9 @@ describe ActionCableListener do 'notification.deleted', { account_id: notification.account_id, - notification: notification.push_event_data, + notification: { + id: notification.id + }, unread_count: 1, count: 1 }