From 1886d4ce081ba2105dd2793e9bf4fc2c24f85184 Mon Sep 17 00:00:00 2001 From: Shivam Mishra Date: Fri, 14 Apr 2023 16:48:28 +0530 Subject: [PATCH] fix: response body in twitter callback (#6907) * fix: response body * fix: tests --- app/controllers/twitter/callbacks_controller.rb | 2 +- spec/controllers/twitter/callbacks_controller_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/controllers/twitter/callbacks_controller.rb b/app/controllers/twitter/callbacks_controller.rb index 19a61f819..616adb816 100644 --- a/app/controllers/twitter/callbacks_controller.rb +++ b/app/controllers/twitter/callbacks_controller.rb @@ -62,7 +62,7 @@ class Twitter::CallbacksController < Twitter::BaseController return unless response.status.to_i == 200 - parsed_user_profile = JSON.parse(response.read_body) + parsed_user_profile = response.body ::Avatar::AvatarFromUrlJob.perform_later(inbox, parsed_user_profile['profile_image_url_https']) end diff --git a/spec/controllers/twitter/callbacks_controller_spec.rb b/spec/controllers/twitter/callbacks_controller_spec.rb index 3ca4a46f6..983b5c681 100644 --- a/spec/controllers/twitter/callbacks_controller_spec.rb +++ b/spec/controllers/twitter/callbacks_controller_spec.rb @@ -6,7 +6,7 @@ RSpec.describe 'Twitter::CallbacksController', type: :request do let(:raw_response) { double } let(:user_object_rsponse) do OpenStruct.new( - read_body: '{"profile_background_color":"000000","profile_background_image_url":"http:\\/\\/abs.twimg.com\\/images\\/themes\\/theme1\\/bg.png"}', + body: '{"profile_background_color":"000000","profile_background_image_url":"http:\\/\\/abs.twimg.com\\/images\\/themes\\/theme1\\/bg.png"}', status: 200, success?: true )