From 14c53b8b5449e675ce339223ddd0e43e43a4ebdb Mon Sep 17 00:00:00 2001 From: Jordan Brough Date: Thu, 24 Mar 2022 02:20:04 -0600 Subject: [PATCH] chore: Use "contain_exactly" in some tests (#4243) --- .../api/v1/accounts/bulk_actions_controller_spec.rb | 12 ++++++------ spec/listeners/automation_rule_listener_spec.rb | 6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/spec/controllers/api/v1/accounts/bulk_actions_controller_spec.rb b/spec/controllers/api/v1/accounts/bulk_actions_controller_spec.rb index 598b2789c..27376b84f 100644 --- a/spec/controllers/api/v1/accounts/bulk_actions_controller_spec.rb +++ b/spec/controllers/api/v1/accounts/bulk_actions_controller_spec.rb @@ -109,8 +109,8 @@ RSpec.describe 'Api::V1::Accounts::BulkActionsController', type: :request do expect(response).to have_http_status(:success) end - expect(Conversation.first.label_list).to eq(%w[support priority_customer]) - expect(Conversation.second.label_list).to eq(%w[support priority_customer]) + expect(Conversation.first.label_list).to contain_exactly('support', 'priority_customer') + expect(Conversation.second.label_list).to contain_exactly('support', 'priority_customer') end end end @@ -126,8 +126,8 @@ RSpec.describe 'Api::V1::Accounts::BulkActionsController', type: :request do params = { type: 'Conversation', ids: Conversation.first(3).pluck(:display_id), labels: { remove: %w[support] } } - expect(Conversation.first.label_list).to eq(%w[support priority_customer]) - expect(Conversation.second.label_list).to eq(%w[support priority_customer]) + expect(Conversation.first.label_list).to contain_exactly('support', 'priority_customer') + expect(Conversation.second.label_list).to contain_exactly('support', 'priority_customer') perform_enqueued_jobs do post "/api/v1/accounts/#{account.id}/bulk_actions", @@ -137,8 +137,8 @@ RSpec.describe 'Api::V1::Accounts::BulkActionsController', type: :request do expect(response).to have_http_status(:success) end - expect(Conversation.first.label_list).to eq(['priority_customer']) - expect(Conversation.second.label_list).to eq(['priority_customer']) + expect(Conversation.first.label_list).to contain_exactly('priority_customer') + expect(Conversation.second.label_list).to contain_exactly('priority_customer') end end end diff --git a/spec/listeners/automation_rule_listener_spec.rb b/spec/listeners/automation_rule_listener_spec.rb index 8a24a7ea1..ff289a6dd 100644 --- a/spec/listeners/automation_rule_listener_spec.rb +++ b/spec/listeners/automation_rule_listener_spec.rb @@ -77,7 +77,7 @@ describe AutomationRuleListener do listener.conversation_status_changed(event) conversation.reload - expect(conversation.labels.pluck(:name)).to eq(%w[support priority_customer]) + expect(conversation.labels.pluck(:name)).to contain_exactly('support', 'priority_customer') end it 'triggers automation rule to assign best agents' do @@ -177,7 +177,7 @@ describe AutomationRuleListener do listener.conversation_updated(event) conversation.reload - expect(conversation.labels.pluck(:name)).to eq(%w[support priority_customer]) + expect(conversation.labels.pluck(:name)).to contain_exactly('support', 'priority_customer') end it 'triggers automation rule to assign best agents' do @@ -268,7 +268,7 @@ describe AutomationRuleListener do listener.message_created(event) conversation.reload - expect(conversation.labels.pluck(:name)).to eq(%w[support priority_customer]) + expect(conversation.labels.pluck(:name)).to contain_exactly('support', 'priority_customer') end it 'triggers automation rule to assign best agent' do