fix: Use bus.$off to remove listeners on destroy (#3478)

2021-11-29 21:15:36 -08:00
parent 86dfdfb9ab
commit 0899f62912
8 changed files with 44 additions and 24 deletions
--- a/app/javascript/dashboard/components/SnackbarContainer.vue
+++ b/app/javascript/dashboard/components/SnackbarContainer.vue
@@ -29,12 +29,16 @@ export default {
  },

  mounted() {
-    bus.$on('newToastMessage', message => {
-      this.snackMessages.push({ key: new Date().getTime(), message });
-      window.setTimeout(() => {
-        this.snackMessages.splice(0, 1);
-      }, this.duration);
-    });
+    bus.$on('newToastMessage', this.onNewToastMessage);
+  },
+  beforeDestroy() {
+    bus.$off('newToastMessage', this.onNewToastMessage);
+  },
+  onNewToastMessage(message) {
+    this.snackMessages.push({ key: new Date().getTime(), message });
+    window.setTimeout(() => {
+      this.snackMessages.splice(0, 1);
+    }, this.duration);
  },
 };
 </script>