Merge branch 'hotfix/1.22.1' into develop
# Conflicts: # db/schema.rb
This commit is contained in:
40
spec/models/contact_inbox_spec.rb
Normal file
40
spec/models/contact_inbox_spec.rb
Normal file
@@ -0,0 +1,40 @@
|
||||
# frozen_string_literal: true
|
||||
|
||||
require 'rails_helper'
|
||||
|
||||
RSpec.describe ContactInbox do
|
||||
describe 'pubsub_token' do
|
||||
let(:contact_inbox) { create(:contact_inbox) }
|
||||
|
||||
it 'gets created on object create' do
|
||||
obj = contact_inbox
|
||||
expect(obj.pubsub_token).not_to eq(nil)
|
||||
end
|
||||
|
||||
it 'does not get updated on object update' do
|
||||
obj = contact_inbox
|
||||
old_token = obj.pubsub_token
|
||||
obj.update(source_id: '234234323')
|
||||
expect(obj.pubsub_token).to eq(old_token)
|
||||
end
|
||||
|
||||
it 'backfills pubsub_token on call for older objects' do
|
||||
obj = create(:contact_inbox)
|
||||
# to replicate an object with out pubsub_token
|
||||
# rubocop:disable Rails/SkipsModelValidations
|
||||
obj.update_column(:pubsub_token, nil)
|
||||
# rubocop:enable Rails/SkipsModelValidations
|
||||
|
||||
obj.reload
|
||||
|
||||
# ensure the column is nil in database
|
||||
results = ActiveRecord::Base.connection.execute('Select * from contact_inboxes;')
|
||||
expect(results.first['pubsub_token']).to eq(nil)
|
||||
|
||||
new_token = obj.pubsub_token
|
||||
obj.update(source_id: '234234323')
|
||||
# the generated token shoul be persisted in db
|
||||
expect(obj.pubsub_token).to eq(new_token)
|
||||
end
|
||||
end
|
||||
end
|
||||
@@ -11,20 +11,4 @@ RSpec.describe Contact do
|
||||
it { is_expected.to belong_to(:account) }
|
||||
it { is_expected.to have_many(:conversations).dependent(:destroy_async) }
|
||||
end
|
||||
|
||||
describe 'pubsub_token' do
|
||||
let(:user) { create(:user) }
|
||||
|
||||
it 'gets created on object create' do
|
||||
obj = user
|
||||
expect(obj.pubsub_token).not_to eq(nil)
|
||||
end
|
||||
|
||||
it 'does not get updated on object update' do
|
||||
obj = user
|
||||
old_token = obj.pubsub_token
|
||||
obj.update(name: 'test')
|
||||
expect(obj.pubsub_token).to eq(old_token)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
@@ -399,7 +399,8 @@ RSpec.describe Conversation, type: :model do
|
||||
additional_attributes: {},
|
||||
meta: {
|
||||
sender: conversation.contact.push_event_data,
|
||||
assignee: conversation.assignee
|
||||
assignee: conversation.assignee,
|
||||
hmac_verified: conversation.contact_inbox.hmac_verified
|
||||
},
|
||||
id: conversation.display_id,
|
||||
messages: [],
|
||||
|
||||
Reference in New Issue
Block a user